SKS use one service #3711
SKS use one service #3711
Conversation
For knative#1997. This will be reused in HPA and KPA changes.
There was a problem hiding this comment.
@vagababov: 0 warnings.
In response to this:
/lint
/hold
This based on code from #3709, #3704, #3705, so wait for them to go in.For #1997
Proposed Changes
- Since it seems Istio cannot handle 4 services per revision, we'll remove one from SKS
- In the next PR we'll propagate it throughout the KPA to revision
- Retire the service creation in revision
- If that succeeds, we'll bring this one back. Hopefully, with 3 services istio will survive scale to 50.
:sad: 😭
/cc @mattmoor
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
|
The following is the coverage report on pkg/.
|
|
/hold cancel |
|
All dependencies are in |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mattmoor, vagababov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* Use generic pkg/resources helpers for endpoint counting * Move SKS helpers to a shared place. For knative#1997. This will be reused in HPA and KPA changes. * some transient state * remove public service and endpoint reconciliation * remove public service and endpoint reconciliation * formatting unification
* Use generic pkg/resources helpers for endpoint counting * Move SKS helpers to a shared place. For knative#1997. This will be reused in HPA and KPA changes. * some transient state * remove public service and endpoint reconciliation * remove public service and endpoint reconciliation * formatting unification
/lint
/hold
This based on code from #3709, #3704, #3705, so wait for them to go in.
For #1997
Proposed Changes
:sad: 😭
/cc @mattmoor