Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move SKS helpers to a shared place. #3704

Merged
merged 1 commit into from
Apr 10, 2019
Merged

Move SKS helpers to a shared place. #3704

merged 1 commit into from
Apr 10, 2019

Conversation

vagababov
Copy link
Contributor

For #1997.
This will be reused in HPA and KPA changes.

/lint

/cc @mattmoor

@vagababov
Move SKS helpers to a shared place.
4d2b5b0 
For knative#1997.
This will be reused in HPA and KPA changes.
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Apr 9, 2019
@knative-prow-robot knative-prow-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 9, 2019
knative-prow-robot
knative-prow-robot reviewed Apr 9, 2019
View reviewed changes
Copy link
Contributor

@knative-prow-robot knative-prow-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vagababov: 0 warnings.

In response to this:

For #1997.
This will be reused in HPA and KPA changes.

/lint

/cc @mattmoor

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot added the area/API API objects and controllers label Apr 9, 2019
@knative-metrics-robot
Copy link

The following is the coverage report on pkg/.
Say /test pull-knative-serving-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/v1alpha1/serverlessservice/serverlessservice.go Do not exist 89.2%

@vagababov vagababov mentioned this pull request Apr 9, 2019
Merged
mattmoor
mattmoor reviewed Apr 10, 2019
View reviewed changes
Copy link
Member

@mattmoor mattmoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 10, 2019
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mattmoor, vagababov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 107012a into knative:master Apr 10, 2019
@vagababov vagababov deleted the sks-functional branch April 11, 2019 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattmoor mattmoor mattmoor left review comments

@knative-prow-robot knative-prow-robot knative-prow-robot left review comments

Assignees

@mattmoor mattmoor

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/API API objects and controllers cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vagababov @knative-metrics-robot @knative-prow-robot @mattmoor @googlebot