Generic sks helpers for pa #3705
Conversation
|
/retest |
|
/test pull-knative-serving-integration-tests |
|
/test pull-knative-serving-upgrade-tests |
|
🐲 |
|
/test pull-knative-serving-integration-tests ☠️ |
|
/test pull-knative-serving-integration-tests 🐶 🐱 🦈 |
|
/test pull-knative-serving-upgrade-tests |
| package names | ||
|
|
||
| // SKSName returns the name of the SKS resource that backs this PA. | ||
| func SKSName(paName string) string { |
There was a problem hiding this comment.
nit: Name is redundant with the package names
| @@ -17,7 +17,7 @@ limitations under the License. | |||
| // Package names contains name generating functions for the pod autoscalers. | |||
| package names | |||
|
|
|||
| // SKSName returns the name of the SKS resource that backs this PA. | |||
| func SKSName(paName string) string { | |||
| // SKSreturns the name of the SKS resource that backs this PA. | |||
There was a problem hiding this comment.
ouais, I notice :)
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mattmoor, vagababov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
The following is the coverage report on pkg/.
|
For #1997
Add the helpers for the PA implementations to reconcile SKS resources: creation, naming, etc.
In future other shared things can go there.
/cc @mattmoor