Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Component walkthrough #2329

Closed
10 of 26 tasks
MadsBuchmann opened this issue Jun 13, 2022 · 0 comments
Closed
10 of 26 tasks

Component walkthrough #2329

MadsBuchmann opened this issue Jun 13, 2022 · 0 comments

Comments

@MadsBuchmann
Copy link
Contributor

MadsBuchmann commented Jun 13, 2022

Components

Accordion

Action sheet

Alert

  • The alert shouldn't slide in from the bottom on desktop - but appear in the middle of the screen... Somehow, more design needed. On mobile it should still appear from bottom

Button

Looks good!

Calendar

  • Look into swapping out with new datetime component from ionic 6. The year selector experience might be a bit iffy on desktop as it uses a native like selector.

Checkbox

  • we could consider creating some sort of "checkbox-group" component to semantically tie the checkboxes together. Might be more accessibility releated.

Chip

Dropdown

FAB Sheet

... Should generally not be used on desktop. It is a mobile pattern.

  • Write guidelines in the cookbook that it should not be used on desktop

Item Picker

List Component

Modal

  • It does not recieve focus when it opens. If you use only keyboard it's impossible to navigate the modal. But consumers can programatically set focus inside if necessary. - Solved via Ionic 6 upgrade!! ~~~~~ dance dance dance ~~~~~

Range

  • (nice to have) Has no label showing value when using keyboard. Might be more of an accessibility thing.

Reorder list

Segmented Control

Slide

tabs

  • tabs does not load until pressed the second time. Might be related to onPush. Might just be a cookbook issue 🤷
  • The menu button does not react on space and enter
  • Totally lacks interaction states

Toggle button

  • Rewrite toggle button to stateful button. Right now we're swapping it out and this removes the focus.
@alxzak alxzak closed this as completed Dec 15, 2022
@alxzak alxzak moved this to ✅ Done in Kirby Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

2 participants