Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cancel button on action sheet does not get any focus styles #2340

Closed
Tracked by #2329
RasmusKjeldgaard opened this issue Jun 15, 2022 · 0 comments · Fixed by #2389
Closed
Tracked by #2329

Cancel button on action sheet does not get any focus styles #2340

RasmusKjeldgaard opened this issue Jun 15, 2022 · 0 comments · Fixed by #2389
Assignees
@jkaltoft
Labels
🟢 Ready for release
Milestone
Interaction States

Comments

@RasmusKjeldgaard
Copy link
Collaborator

RasmusKjeldgaard commented Jun 15, 2022 •
edited
Loading

It should have a blue outline.
@RasmusKjeldgaard RasmusKjeldgaard mentioned this issue Jun 15, 2022
Closed
26 tasks
@RasmusKjeldgaard RasmusKjeldgaard changed the title The cancel button does not get any focus styles Cancel button on action sheet does not get any focus styles Jun 15, 2022
@RasmusKjeldgaard RasmusKjeldgaard moved this to 📙 Backlog in Kirby Jun 15, 2022
@alxzak alxzak added this to the Interaction States milestone Jun 16, 2022
@jkaltoft jkaltoft self-assigned this Jul 4, 2022
@jkaltoft jkaltoft moved this from 📙 Backlog to 🚀 In Progress in Kirby Jul 4, 2022
jkaltoft added a commit that referenced this issue Jul 4, 2022
@jkaltoft
💄 Use apply-focus.visible interaction state mixin
a2dd65a 
Closes #2340
@jkaltoft jkaltoft mentioned this issue Jul 4, 2022
Merged
7 tasks
@jkaltoft jkaltoft moved this from 🚀 In Progress to 👀 Review in progess in Kirby Jul 4, 2022
@jkaltoft jkaltoft moved this from 👀 Review in progess to 🔎 Review pending in Kirby Jul 4, 2022
@jkaltoft jkaltoft linked a pull request Jul 4, 2022 that will close this issue
Apply focus styles to Action Sheet cancel button #2389
Merged
7 tasks
@RasmusKjeldgaard RasmusKjeldgaard moved this from 🔎 Review pending to 👀 Review in progess in Kirby Aug 1, 2022
@jkaltoft jkaltoft moved this from 👀 Review in progess to ✅ Done in Kirby Aug 5, 2022
@jkaltoft jkaltoft closed this as completed Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jkaltoft jkaltoft

Labels
🟢 Ready for release
Projects
Kirby
Archived in project
Milestone
Interaction States
Development

Successfully merging a pull request may close this issue.

Apply focus styles to Action Sheet cancel button kirbydesign/designsystem
3 participants
@jkaltoft @RasmusKjeldgaard @alxzak