Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Change background color on focus inside accordion, list, action sheet and dropdown #2236

Closed
1 of 11 tasks
RasmusKjeldgaard opened this issue May 9, 2022 · 3 comments · Fixed by #2420
Closed
1 of 11 tasks
Assignees
Labels
enhancement New feature or request 🧑‍🎨 Needs UX NOT Tech refined Needs Tech kickoff - solution outlined and agreed 🟢 Ready for release

Comments

@RasmusKjeldgaard
Copy link
Collaborator

Describe the enhancement

The current solution for focus with a blue outline around elements is not suitable for some of our elements:

  • List items
  • Accordion items
  • Buttons in action sheet
  • Buttons inside an opened dropdown

Instead we want to change the background of these to be similar to active state for the time being.

A small refactor of dropdown is possibly needed here as the current focus-behavior is not exactly as we want it. Right now, when using the arrow keys the elements are selected. They should instead have focus state when browsed with arrow keys, and only be selected (bold text and checkmark) when enter or space is pressed.


Checklist:

The following tasks should be carried out in sequence in order to follow the process of contributing correctly.

Refinement

  • Request that the issue is UX refined; do not proceed until this is done.
  • Request that the issue is tech refined; do not proceed until this is done.

Implementation

The contributor who wants to implement this issue should:

  • Make sure you have read: "Before you get coding".
  • Signal to others you are working on the issue by assigning yourself.
  • Create a branch from the stable branch following our branch naming convention.
  • Publish a WIP implementation to Github as a draft PR and ask for feedback.
  • Make sure you have implemented tests following the guidelines in: "The good: Test".
  • Update the cookbook with examples and showcases.

Review

Once the issue has been implemented and is ready for review:

  • Do a self-review.
  • Create a pull-request. If you created a draft PR during implementation you can just mark that as "ready for review".
@RasmusKjeldgaard RasmusKjeldgaard added enhancement New feature or request NOT Tech refined Needs Tech kickoff - solution outlined and agreed NOT Prioritized Issue not yet prioritized and added to a Milestone labels May 9, 2022
@RasmusKjeldgaard RasmusKjeldgaard added this to the Interaction States milestone May 9, 2022
@alxzak alxzak added this to Kirby May 9, 2022
@alxzak alxzak removed the NOT Prioritized Issue not yet prioritized and added to a Milestone label May 18, 2022
@MadsBuchmann MadsBuchmann mentioned this issue Jun 13, 2022
26 tasks
@RasmusKjeldgaard RasmusKjeldgaard moved this to 📙 Backlog in Kirby Jun 15, 2022
@jkaltoft
Copy link
Collaborator

jkaltoft commented Jul 7, 2022

I think the background change should to be similar to hover state instead of active state. Active state background color change should be applied when "activating" or "submitting" with ENTER and/or SPACE key.

@jkaltoft jkaltoft moved this from 📙 Backlog to 🚀 In Progress in Kirby Aug 12, 2022
@jkaltoft jkaltoft self-assigned this Aug 12, 2022
@jkaltoft jkaltoft removed the status in Kirby Aug 12, 2022
@jkaltoft jkaltoft moved this to 🚀 In Progress in Kirby Aug 12, 2022
@jkaltoft
Copy link
Collaborator

If possible we should include focus on tabs in "desktop view", see #2244 (comment)

@jkaltoft jkaltoft linked a pull request Aug 15, 2022 that will close this issue
10 tasks
@jkaltoft
Copy link
Collaborator

The Dropdown parts should be solved by #2342. Skipping those in this issue.

@jkaltoft jkaltoft moved this from 🚀 In Progress to 💤 Impeeded in Kirby Aug 16, 2022
@jkaltoft jkaltoft moved this from 💤 Impeeded to 🚀 In Progress in Kirby Aug 17, 2022
@jkaltoft jkaltoft moved this from 🚀 In Progress to 🔎 Review pending in Kirby Aug 17, 2022
@jkaltoft jkaltoft moved this from 🔎 Review pending to ✅ Done in Kirby Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request 🧑‍🎨 Needs UX NOT Tech refined Needs Tech kickoff - solution outlined and agreed 🟢 Ready for release
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants