Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Segmented control - Align keyboard interactions between the different modes #2347

Closed
Tracked by #2329
RasmusKjeldgaard opened this issue Jun 15, 2022 · 1 comment · Fixed by #2417
Closed
Tracked by #2329

Segmented control - Align keyboard interactions between the different modes #2347

RasmusKjeldgaard opened this issue Jun 15, 2022 · 1 comment · Fixed by #2417
Assignees
@jkaltoft @RasmusKjeldgaard
Labels
🟢 Ready for release
Milestone
Interaction States

Comments

@RasmusKjeldgaard
Copy link
Collaborator

The arrow key functionality for the default Segmented Control has been introduced by the Ionic 6 upgrade. Chip mode should use the same method as default mode (arrow keys once it has received focus).
@RasmusKjeldgaard RasmusKjeldgaard mentioned this issue Jun 15, 2022
Closed
26 tasks
@RasmusKjeldgaard RasmusKjeldgaard moved this to 📙 Backlog in Kirby Jun 15, 2022
@alxzak alxzak added this to the Interaction States milestone Jun 16, 2022
@jkaltoft jkaltoft self-assigned this Jul 4, 2022
@jkaltoft jkaltoft moved this from 📙 Backlog to 🚀 In Progress in Kirby Jul 4, 2022
jkaltoft added a commit that referenced this issue Jul 5, 2022
@jkaltoft
🚧 Create outline for solution
839b723 
Closes #2347
@jkaltoft jkaltoft mentioned this issue Jul 5, 2022
Closed
7 tasks
@jkaltoft jkaltoft linked a pull request Jul 5, 2022 that will close this issue
Align keyboard interactions on Segmented Control #2394
Closed
7 tasks
@jkaltoft
Copy link
Collaborator

jkaltoft commented Jul 7, 2022

There seems to quite a lot more work in this than I first expected. I'm putting it on hold for the summer until we can collaborate on a solution.

@jkaltoft jkaltoft moved this from 🚀 In Progress to 💤 Impeeded in Kirby Jul 7, 2022
@RasmusKjeldgaard RasmusKjeldgaard self-assigned this Aug 10, 2022
@RasmusKjeldgaard RasmusKjeldgaard moved this from 💤 Impeeded to 🚀 In Progress in Kirby Aug 10, 2022
@RasmusKjeldgaard RasmusKjeldgaard mentioned this issue Aug 12, 2022
Merged
7 tasks
@RasmusKjeldgaard RasmusKjeldgaard moved this from 🚀 In Progress to 🔎 Review pending in Kirby Aug 18, 2022
@jkaltoft jkaltoft moved this from 🔎 Review pending to 👀 Review in progess in Kirby Aug 18, 2022
@RasmusKjeldgaard RasmusKjeldgaard moved this from 👀 Review in progess to ✅ Done in Kirby Aug 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jkaltoft jkaltoft

@RasmusKjeldgaard RasmusKjeldgaard

Labels
🟢 Ready for release
Projects
Kirby
Archived in project
Milestone
Interaction States
3 participants
@jkaltoft @RasmusKjeldgaard @alxzak