Leaflet proj refactor #126
Conversation
…l projections folder
…lts in discontinuities
Leaflet proj refactor (Leaflet beta 1.0.0)
When you try to create a L.Proj.GeoJSON layer with no data (to add it
after layer creation):
var layer = L.Proj.geoJson();
layer.addData(geojson).addTo(map);
You get an exception:
Uncaught TypeError: Cannot read property 'features' of undefined
Conflicts:
src/proj4leaflet.js
…ethode, which causes a crash
update package.json to work with beta
…les to use leaflet from lib folder
Leaflet proj refactor
Fixed zoom returning NaN if passed in scale bigger than scales defined
|
I agree. Although there are quite a lot of conflicts to fix and the documentation also would need to be updated to reflect the changes and reference the Leaflet 0.7 users to the commit before the merge of this pull request. Or should there be a release for the current code in master targeting Leaflet 0.7 and then a release of the new code in master targeting Leaflet 1.0? This looks quite big since |
|
I don't think there has been any major changes or releases for 0.7, not that i can remember, no new festures. I think we need to go through the docs since it has changed and uses gh-pages in master. I dont think its updated at all for 1.0. That is the only thing that i can recall |
|
Yeah, true, :) I agree on that also, for me it looked that quite a lot of things could have been and probably should have been merged into master already, since they were not Leaflet 1.0 specific, but seems that those 2 branches just started to live life on their own at one point. If we take a look at https://github.com/kartena/Proj4Leaflet/releases then the 0.7.2 release was a year ago and since then there has been 6 commits to the As for 1.0.0-beta.2 release there are 16 commits since last year 1.0.0-beta.2...leaflet-proj-refactor so after fixing the documentation, conflicts and merging this PR in a stable release 1.0.0 would be really awesome to get out. I think the documentation in |
|
Any progress on this ? |
|
I am going to work on this now, hopefully I will get through it today. |
to L.Proj.CRS. Test that it works.
Updated dependency to Leaflet 1.0.3.
| <link rel="stylesheet" href="http://cdn.leafletjs.com/leaflet/v0.7.7/leaflet.css" /> | ||
| </head> | ||
| <body> | ||
| <div id="map"></div> | ||
| <script src="http://cdn.leafletjs.com/leaflet/v0.7.7/leaflet.js"></script> | ||
| >>>>>>> master |
There was a problem hiding this comment.
@pthorin I saw that this is merged already, but looks like this was not fixed before merging.
There was a problem hiding this comment.
Oops, I missed pressing save on that one! I'm working on trying to get automated tests so can fix that soon as well. Thanks for noticing!
There was a problem hiding this comment.
:) Heh, good. Great job!
Leaflet 1.0 is out since a couple of weeks, and there's no reason Proj4Leaflet's
masterbranch should use 0.7.