Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update package.json to work with beta #117

Merged

Conversation

semone
Copy link
Contributor

@semone semone commented Apr 4, 2016

Fix the package.json so that npm install git+https://git@github.com/kartena/proj4leaflet.git/#leaflet-proj-refactor, works properly. Meaning that it will install the correct proj4 and leaflet-version.

@dannybloe
Copy link

Why are you actually defining dependencies here? Shouldn't it just use the Leaflet instance that is actually running/loaded? Isn't defining peer dependencies enough? For all I understand, Proj4Leaflet is a plugin and shouldn't have it's own Leaflet imo.

@semone
Copy link
Contributor Author

semone commented Apr 5, 2016

According to the Leaflet plugin guide That is how you do it.
The reason I can see for it not defining it as a peer dependency is that if you install a lot of leaflet plugins that peer depends on different versions of Leaflet it won't get pretty, meaning if some plugins are locked down to a specific version.

@pthorin pthorin merged commit ec8faa3 into kartena:leaflet-proj-refactor Apr 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants