Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leaflet proj refactor #120

Merged
merged 4 commits into from
Sep 5, 2016

Conversation

semone
Copy link
Contributor

@semone semone commented Aug 20, 2016

Updated to use leaflet 1.0.0-rc.3

I updated leaflet and proj4 in the lib folder and pointed the examples to this folder. That makes it easier to update the examples sice you dont have to go into every example and change the url.

@pthorin
Copy link

pthorin commented Aug 22, 2016

There seems to be an issue with the attribution of examples/wms/script.js. I don't think the copyright is owned by Open Street Map.

@semone
Copy link
Contributor Author

semone commented Aug 23, 2016

Maybe I should write OpenStreetMap Contributors instead? I went on what this link is saying. But if it should be correct it should say Contributors as well.
https://www.havochvatten.se/hav/samordning--fakta/kartor--gis/karttjanster/karttjanster/havs-grundkartor.html

@pthorin
Copy link

pthorin commented Aug 23, 2016

Oh, sorry, my bad. I assumed, which is never good. But yes, "OpenStreetMap contributors" is the correct form.

@semone
Copy link
Contributor Author

semone commented Aug 23, 2016

Now it should be fixed 👍

@perliedman
Copy link
Contributor

Is it really desirable to have our own copy of Leaflet inside this repo? I usually prefer using some CDN, but I guess that can be debated.

@semone
Copy link
Contributor Author

semone commented Aug 23, 2016

I was thinking no at first as well. I did it because in the future then you only have to update that leaflet version to check the examples and the tests, so it was only done to remove the step of updating all examples and test with the new CDN url.

But maybe there is a better way of doing that? Using browserify maybe?

@perliedman
Copy link
Contributor

Hm, I see your point. Avoiding to change the URL in a million places is also good :)

You can do it with Browserify, but then we'd need a build step, which makes it harder for people to just clone and check the examples.

So, I guess you've convinced me 😄

@pthorin pthorin merged commit 6feb358 into kartena:leaflet-proj-refactor Sep 5, 2016
@pthorin
Copy link

pthorin commented Sep 5, 2016

Good job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants