Migrate mssql domain service to new module system #2430

DanielFran · 2022-07-06T23:07:10Z

codecov · 2022-07-07T00:47:45Z

Codecov Report

Merging #2430 (ff3036b) into main (7e75633) will not change coverage.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##                main     #2430    +/-   ##
============================================
  Coverage     100.00%   100.00%            
+ Complexity      2455      2307   -148     
============================================
  Files            550       537    -13     
  Lines           9564      9178   -386     
  Branches         230       230            
============================================
- Hits            9564      9178   -386

Impacted Files	Coverage Δ
...va/tech/jhipster/lite/common/domain/WordUtils.java	`100.00% <ø> (ø)`
...re/secondary/FileSystemDockerImagesRepository.java	`100.00% <ø> (ø)`
...ildtool/generic/domain/BuildToolDomainService.java	`100.00% <ø> (ø)`
...lite/generator/buildtool/gradle/domain/Gradle.java	`100.00% <ø> (ø)`
...r/buildtool/gradle/domain/GradleDomainService.java	`100.00% <ø> (ø)`
...ool/maven/application/MavenApplicationService.java	`100.00% <ø> (ø)`
...r/lite/generator/buildtool/maven/domain/Maven.java	`100.00% <ø> (ø)`
...tor/buildtool/maven/domain/MavenDomainService.java	`100.00% <ø> (ø)`
...te/generator/client/svelte/core/domain/Svelte.java	`100.00% <ø> (ø)`
...te/generator/project/domain/ProjectRepository.java	`100.00% <ø> (ø)`
... and 122 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e75633...ff3036b. Read the comment docs.

pascalgrimaud · 2022-07-07T12:39:48Z

@DanielFran : can you fix the CI plz?

…16-ubuntu-20.04

Bumps [vue-tsc](https://github.com/johnsoncodehk/volar/tree/HEAD/packages/vue-tsc) from 0.38.2 to 0.38.3. - [Release notes](https://github.com/johnsoncodehk/volar/releases) - [Changelog](https://github.com/johnsoncodehk/volar/blob/master/CHANGELOG.md) - [Commits](https://github.com/johnsoncodehk/volar/commits/v0.38.3/packages/vue-tsc) --- updated-dependencies: - dependency-name: vue-tsc dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>

Bumps [@playwright/test](https://github.com/Microsoft/playwright) from 1.23.1 to 1.23.2. - [Release notes](https://github.com/Microsoft/playwright/releases) - [Commits](microsoft/playwright@v1.23.1...v1.23.2) --- updated-dependencies: - dependency-name: "@playwright/test" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>

Bumps confluentinc/cp-kafka from 7.1.1 to 7.2.0. --- updated-dependencies: - dependency-name: confluentinc/cp-kafka dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>

Bumps [vue-tsc](https://github.com/johnsoncodehk/volar/tree/HEAD/packages/vue-tsc) from 0.38.2 to 0.38.3. - [Release notes](https://github.com/johnsoncodehk/volar/releases) - [Changelog](https://github.com/johnsoncodehk/volar/blob/master/CHANGELOG.md) - [Commits](https://github.com/johnsoncodehk/volar/commits/v0.38.3/packages/vue-tsc) --- updated-dependencies: - dependency-name: vue-tsc dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>

Bumps [svelte](https://github.com/sveltejs/svelte) from 3.48.0 to 3.49.0. - [Release notes](https://github.com/sveltejs/svelte/releases) - [Changelog](https://github.com/sveltejs/svelte/blob/master/CHANGELOG.md) - [Commits](sveltejs/svelte@v3.48.0...v3.49.0) --- updated-dependencies: - dependency-name: svelte dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>

…c-0.38.3 chore(deps-dev): bump vue-tsc from 0.38.2 to 0.38.3

…ources/generator/dependencies/confluentinc/cp-kafka-7.2.0 chore(deps): bump confluentinc/cp-kafka from 7.1.1 to 7.2.0 in /src/main/resources/generator/dependencies

…in/resources/generator/dependencies/common/playwright/test-1.23.2 chore(deps-dev): bump @playwright/test from 1.23.1 to 1.23.2 in /src/main/resources/generator/dependencies/common

…in/resources/generator/dependencies/vue/vue-tsc-0.38.3 chore(deps-dev): bump vue-tsc from 0.38.2 to 0.38.3 in /src/main/resources/generator/dependencies/vue

This is not really a migration since gradle support is currently not working. We agreed to keep the templating and remove the endpoints. I also deleted some unused methods in project repository in the process

Gradle migration

Bumps [pinia](https://github.com/vuejs/pinia) from 2.0.15 to 2.0.16. - [Release notes](https://github.com/vuejs/pinia/releases) - [Commits](https://github.com/vuejs/pinia/compare/pinia@2.0.15...pinia@2.0.16) --- updated-dependencies: - dependency-name: pinia dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>

Bumps [@sveltejs/kit](https://github.com/sveltejs/kit/tree/HEAD/packages/kit) from 1.0.0-next.369 to 1.0.0-next.370. - [Release notes](https://github.com/sveltejs/kit/releases) - [Changelog](https://github.com/sveltejs/kit/blob/master/packages/kit/CHANGELOG.md) - [Commits](https://github.com/sveltejs/kit/commits/@sveltejs/kit@1.0.0-next.370/packages/kit) --- updated-dependencies: - dependency-name: "@sveltejs/kit" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>

…n/pinia-2.0.16 chore(deps): bump pinia from 2.0.15 to 2.0.16

…n/src/main/resources/generator/dependencies/svelte/sveltejs/kit-1.0.0-next.370 chore(deps-dev): bump @sveltejs/kit from 1.0.0-next.369 to 1.0.0-next.370 in /src/main/resources/generator/dependencies/svelte

…n/src/main/resources/generator/dependencies/vue/pinia-2.0.16 chore(deps): bump pinia from 2.0.15 to 2.0.16 in /src/main/resources/generator/dependencies/vue

Fix regex replacements

…16-ubuntu-20.04

# Conflicts: # src/main/java/tech/jhipster/lite/generator/server/springboot/database/mssql/domain/MsSQLModuleFactory.java # src/main/java/tech/jhipster/lite/generator/server/springboot/database/mysql/domain/MySQLModuleFactory.java # src/main/java/tech/jhipster/lite/generator/server/springboot/database/sqlcommon/domain/SQLCommonModuleBuilder.java # src/test/java/tech/jhipster/lite/generator/server/springboot/database/mssql/domain/MsSQLModuleFactoryTest.java

CLAassistant · 2022-07-13T10:14:01Z

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
4 out of 5 committers have signed the CLA.

✅ DamnClin
✅ pascalgrimaud
✅ nonomoho
✅ DanielFran
❌ github-actions[bot]
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

pascalgrimaud · 2022-07-13T10:15:49Z

bad "rebase" or "merge remote" :-(

DanielFran · 2022-07-13T16:18:35Z

Superseded by #2547

DanielFran force-pushed the module_mssql branch from 25fa0d6 to 778ad9e Compare July 6, 2022 23:10

DanielFran requested a review from pascalgrimaud July 6, 2022 23:20

DanielFran force-pushed the module_mssql branch from 43d9843 to ae94230 Compare July 6, 2022 23:30

pascalgrimaud added server: spring boot theme: database area: refactoring labels Jul 7, 2022

DanielFran added 11 commits July 7, 2022 14:00

Define variable in sql common builder for testcontainer artifact id

2ae6458

Add missing 2 sql common hibernate properties

e78885e

Migrate mssql domain service to new module system

96e8ea9

Add cucumber tests

008c48f

Add cucumber tests

6337168

Remove unused constant

9da2928

Fix rename class

36dd822

Fix merge

02f5bdb

Fix test

584603b

Fix Sonar

d3427e7

Fix issue

27ea736

DanielFran force-pushed the module_mssql branch from 0c7be4f to 27ea736 Compare July 7, 2022 13:01

DanielFran and others added 10 commits July 7, 2022 14:29

Update mcr.microsoft.com/mssql/server docker image version to 2019-CU…

0866ba7

…16-ubuntu-20.04

Merge pull request #2437 from jhipster/dependabot/npm_and_yarn/vue-ts…

7c44823

…c-0.38.3 chore(deps-dev): bump vue-tsc from 0.38.2 to 0.38.3

Merge pull request #2440 from jhipster/dependabot/docker/src/main/res…

470b349

…ources/generator/dependencies/confluentinc/cp-kafka-7.2.0 chore(deps): bump confluentinc/cp-kafka from 7.1.1 to 7.2.0 in /src/main/resources/generator/dependencies

Merge pull request #2438 from jhipster/dependabot/npm_and_yarn/src/ma…

452f96a

…in/resources/generator/dependencies/common/playwright/test-1.23.2 chore(deps-dev): bump @playwright/test from 1.23.1 to 1.23.2 in /src/main/resources/generator/dependencies/common

Merge pull request #2441 from jhipster/dependabot/npm_and_yarn/src/ma…

75d67ef

…in/resources/generator/dependencies/vue/vue-tsc-0.38.3 chore(deps-dev): bump vue-tsc from 0.38.2 to 0.38.3 in /src/main/resources/generator/dependencies/vue

DamnClin and others added 23 commits July 12, 2022 17:24

Gradle migration

4687e94

This is not really a migration since gradle support is currently not working. We agreed to keep the templating and remove the endpoints. I also deleted some unused methods in project repository in the process

Merge pull request jhipster#2528 from DamnClin/migrate-gradle

631166b

Gradle migration

Merge pull request jhipster#2535 from jhipster/dependabot/npm_and_yar…

4d8c5ef

…n/pinia-2.0.16 chore(deps): bump pinia from 2.0.15 to 2.0.16

Merge pull request jhipster#2537 from jhipster/dependabot/npm_and_yar…

c201751

…n/src/main/resources/generator/dependencies/svelte/sveltejs/kit-1.0.0-next.370 chore(deps-dev): bump @sveltejs/kit from 1.0.0-next.369 to 1.0.0-next.370 in /src/main/resources/generator/dependencies/svelte

Merge pull request jhipster#2536 from jhipster/dependabot/npm_and_yar…

5ee82fa

…n/src/main/resources/generator/dependencies/vue/pinia-2.0.16 chore(deps): bump pinia from 2.0.15 to 2.0.16 in /src/main/resources/generator/dependencies/vue

Fix regex replacements

d574b4a

Merge pull request jhipster#2532 from DamnClin/fix-regex-replacements

cd4527e

Fix regex replacements

Define variable in sql common builder for testcontainer artifact id

b57811a

Add missing 2 sql common hibernate properties

a887609

Migrate mssql domain service to new module system

81cf019

Add cucumber tests

fffa609

Add cucumber tests

96afd66

Remove unused constant

69b90dd

Fix rename class

53b373a

Fix merge

7884beb

Fix test

951e561

Fix Sonar

ef6ad99

Fix issue

623baaf

Update mcr.microsoft.com/mssql/server docker image version to 2019-CU…

c0fb2d7

…16-ubuntu-20.04

Fix merge

8548bd6

DanielFran marked this pull request as draft July 13, 2022 10:03

DanielFran closed this Jul 13, 2022

DanielFran deleted the module_mssql branch July 13, 2022 14:15

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Migrate mssql domain service to new module system #2430

Migrate mssql domain service to new module system #2430

DanielFran commented Jul 6, 2022

codecov bot commented Jul 7, 2022 •

edited

Loading

pascalgrimaud commented Jul 7, 2022

CLAassistant commented Jul 13, 2022

pascalgrimaud commented Jul 13, 2022

DanielFran commented Jul 13, 2022

Migrate mssql domain service to new module system #2430

Migrate mssql domain service to new module system #2430

Conversation

DanielFran commented Jul 6, 2022

codecov bot commented Jul 7, 2022 • edited Loading

Codecov Report

pascalgrimaud commented Jul 7, 2022

CLAassistant commented Jul 13, 2022

pascalgrimaud commented Jul 13, 2022

DanielFran commented Jul 13, 2022

codecov bot commented Jul 7, 2022 •

edited

Loading