Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gradle migration #2528

Merged
merged 1 commit into from
Jul 12, 2022
Merged

Gradle migration #2528

merged 1 commit into from
Jul 12, 2022

Conversation

DamnClin
Copy link
Collaborator

This is not really a migration since gradle support is currently not
working. We agreed to keep the templating and remove the endpoints.

I also deleted some unused methods in project repository in the process

Close #2503

@codecov
Copy link

codecov bot commented Jul 12, 2022

Codecov Report

Merging #2528 (a6e5c69) into main (aa3cec4) will not change coverage.
The diff coverage is 100.00%.

❗ Current head a6e5c69 differs from pull request most recent head 4687e94. Consider uploading reports for the commit 4687e94 to get more accurate results

@@             Coverage Diff             @@
##                main     #2528   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
+ Complexity      2313      2311    -2     
===========================================
  Files            541       542    +1     
  Lines           9235      9225   -10     
  Branches         221       221           
===========================================
- Hits            9235      9225   -10     
Impacted Files Coverage Δ
...lite/generator/buildtool/gradle/domain/Gradle.java 100.00% <ø> (ø)
...r/buildtool/gradle/domain/GradleDomainService.java 100.00% <ø> (ø)
...te/generator/project/domain/ProjectRepository.java 100.00% <ø> (ø)
...frastructure/secondary/ProjectLocalRepository.java 100.00% <ø> (ø)
...r/buildtool/gradle/domain/GradleModuleFactory.java 100.00% <100.00%> (ø)
...ster/lite/module/domain/JHipsterModuleContext.java 100.00% <0.00%> (ø)
...r/lite/generator/buildtool/maven/domain/Maven.java 100.00% <0.00%> (ø)
...le/domain/properties/JHipsterModuleProperties.java 100.00% <0.00%> (ø)
...tor/buildtool/maven/domain/MavenDomainService.java 100.00% <0.00%> (ø)
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8de7e9...4687e94. Read the comment docs.

@pascalgrimaud
Copy link
Member

minor conflict to resolve, maybe because of some merges, few mins ago

This is not really a migration since gradle support is currently not
working. We agreed to keep the templating and remove the endpoints.

I also deleted some unused methods in project repository in the process
@pascalgrimaud pascalgrimaud merged commit 631166b into jhipster:main Jul 12, 2022
@DamnClin DamnClin deleted the migrate-gradle branch July 13, 2022 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate or delete gradle modules
2 participants