Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate or delete gradle modules #2503

Closed
DamnClin opened this issue Jul 11, 2022 · 6 comments · Fixed by #2528
Closed

Migrate or delete gradle modules #2503

DamnClin opened this issue Jul 11, 2022 · 6 comments · Fixed by #2528

Comments

@DamnClin
Copy link
Collaborator

Gradle modules src/main/java/tech/jhipster/lite/generator/buildtool/gradle allow initialization of a gradle project but after that everything will fail.

I think we should delete that for now to avoid spending time on that. Any though @pascalgrimaud ?

@pascalgrimaud
Copy link
Member

Can we just remove the gradle part in the front, for now? Or just hide the button

@DamnClin
Copy link
Collaborator Author

A plan can be to create the module factory (not the resources) and delete all other parts so we don't lose the business logic BUT we don't need to take more time on that. What do you think?

@pascalgrimaud
Copy link
Member

pascalgrimaud commented Jul 11, 2022

I'm fine so, let's move to module system
It won't impact our users as gradle doesn't work currently

What I'd like is to keep the template in resources, so it can be reused

@atomfrede
Copy link
Member

I vote for migration :) But it would be totally okay to remove it for now, not sure I'll have enough time in the coming days/weeks to do significant contributions to this.

@DamnClin
Copy link
Collaborator Author

Did something, don't hesitate to tell if that wasn't your idea on that :)

@atomfrede
Copy link
Member

Looks okay so far. I'll see to make it work again, maybe after the moving parts have settled a little

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants