-
-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate mssql domain service to new module system #2547
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2547 +/- ##
===========================================
Coverage 100.00% 100.00%
+ Complexity 2315 2301 -14
===========================================
Files 544 542 -2
Lines 9245 9235 -10
Branches 229 229
===========================================
- Hits 9245 9235 -10
Continue to review full report at Codecov.
|
@pascalgrimaud Any clue why CI is failing? |
2566d7d
to
b921e0e
Compare
@pascalgrimaud Locally (in windows) I have mssqlapp that build fine, no issue downloading the docker image!?! |
@pascalgrimaud Found the problem, current configuration only works for 2017 mssql docker image version. |
Don't understand what is the problem in this migration Because I used this feature for my current project for my customer, using same version here https://github.com/jhipster/jhipster-lite/blob/main/src/test/resources/generator/dependencies/Dockerfile#L9 And it works well |
@pascalgrimaud I mean the current configuration for testcontainer. I wanted to use same image version for prod and test like currently in generator-jhipster |
Oh I see, I'm fine to improve this after migration |
@pascalgrimaud Migration is now done |
...tech/jhipster/lite/generator/server/springboot/database/mssql/domain/MsSQLModuleFactory.java
Show resolved
Hide resolved
...tech/jhipster/lite/generator/server/springboot/database/mssql/domain/MsSQLModuleFactory.java
Show resolved
Hide resolved
Can I help on this one? |
@pascalgrimaud @DamnClin I am on holidays since few days, and no access to any pc, so yes, you can rebase and merged it |
closing in favor of #2697 |
Fix #2119