Revert "[JENKINS-75174] Move existing web.xml to web-fragment.xml under core (#10185)"

[timja]

This reverts commit 365d03e, reversing
changes made to 5aca30a.

This PR broke mvn jetty:run, it just hung without starting. Spent awhile thinking it was an issue with my machine or a change I had -.-

See JENKINS-XXXXX.

Testing done

Proposed changelog entries

• human-readable text

Proposed upgrade guidelines

N/A

Submitter checklist

Preview Give feedback

1. The Jira issue, if it exists, is well-described.
2. The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples). Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
3. There is automated testing or an explanation as to why this change has no tests.
4. New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
5. New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
6. New or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
7. For dependency updates, there are links to external changelogs and, if possible, full differentials.
8. For new APIs and extension points, there is a link to at least one consumer.

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

Preview Give feedback

1. There are at least two (2) approvals for the pull request and no outstanding requests for change.
2. Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
3. Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
4. Proper changelog labels are set so that the changelog can be generated automatically.
5. If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
6. If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

[basil]

Looks like jenkinsci/jenkins-test-harness#899 needs to be side-ported to somewhere near https://github.com/jenkinsci/maven-hpi-plugin/blob/d75d6396318fbc1b6ed7363849d57add24422ac0/src/main/java/org/jenkinsci/maven/plugins/hpi/RunMojo.java#L618. While normally I swear by Jeff Bonwick's eternal words of "If it's broken, rip it out", it might not be too much effort to roll forward in this case.

[timja]

Looks like jenkinsci/jenkins-test-harness#899 needs to be side-ported to somewhere near jenkinsci/maven-hpi-plugin@d75d639/src/main/java/org/jenkinsci/maven/plugins/hpi/RunMojo.java#L618. While normally I swear by Jeff Bonwick's eternal words of "If it's broken, rip it out", it might not be too much effort to roll forward in this case.

right now it breaks building / running Jenkins core in development mode and plugins depending on current weekly, we can reapply once ready easily.

[timja]

FYI @Vlatombe

[Vlatombe]

Ack, sorry I forgot to check this use case.

[timja]

Looks like jenkinsci/jenkins-test-harness#899 needs to be side-ported to somewhere near jenkinsci/maven-hpi-plugin@d75d639/src/main/java/org/jenkinsci/maven/plugins/hpi/RunMojo.java#L618. While normally I swear by Jeff Bonwick's eternal words of "If it's broken, rip it out", it might not be too much effort to roll forward in this case.

Maven hpi plugin isn't used in core so I don't think this would fix it?

Both jetty:run and hpi:run are broken

[Vlatombe]

jetty:run -> #10227
hpi:run -> jenkinsci/maven-hpi-plugin#710