Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JENKINS-75174] Allow webapp context configuration to be discovered via Servlet 3.0 discovery #899

Merged
merged 1 commit into from
Jan 22, 2025
Merged

[JENKINS-75174] Allow webapp context configuration to be discovered via Servlet 3.0 discovery #899

merged 1 commit into from
Jan 22, 2025

Conversation

Vlatombe
Copy link
Member

@Vlatombe Vlatombe commented Jan 20, 2025 •
edited
Loading

This will allow Jenkins to leverage web-fragment.xml and Servlet 3.0 annotations.

JENKINS-75174

Downstream change

Testing done

Checked that JenkinsRule-based tests still run as expected, and are able to pick up web fragments when defined and allowed by web.xml (e.g. metadata-complete="false" or missing)

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@Vlatombe Vlatombe marked this pull request as ready for review January 20, 2025 16:52
@Vlatombe Vlatombe changed the title Allow webapp context configuration to be discovered via Servlet 3.0 discovery [JENKINS-75174] Allow webapp context configuration to be discovered via Servlet 3.0 discovery Jan 21, 2025
@Vlatombe Vlatombe mentioned this pull request Jan 21, 2025
Merged
@Vlatombe Vlatombe requested a review from jglick January 21, 2025 13:30
@Vlatombe Vlatombe mentioned this pull request Jan 22, 2025
Merged
6 tasks
@Vlatombe Vlatombe merged commit ad3a58a into jenkinsci:master Jan 22, 2025
15 checks passed
@Vlatombe Vlatombe deleted the configuration-discovery branch January 22, 2025 07:48
This was referenced Jan 22, 2025
Merged
Merged
@jglick jglick mentioned this pull request Jan 22, 2025
Closed
@basil basil mentioned this pull request Jan 31, 2025
Merged
Vlatombe added a commit to Vlatombe/maven-hpi-plugin that referenced this pull request Jan 31, 2025
@Vlatombe
Allowing configuration discovery
f2367eb 
Side-port of jenkinsci/jenkins-test-harness#899
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olamy olamy olamy approved these changes

@jglick jglick Awaiting requested review from jglick

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Vlatombe @olamy