Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert #21 to allow configuration discovery #710

Merged
merged 1 commit into from
Jan 31, 2025

Conversation

Vlatombe
Copy link
Member

I added this line 10 years ago to address a start-up delay (#21 & https://issues.jenkins.io/browse/JENKINS-30067). However I
need now to remove it in order to allow configuration discovery.

I couldn't notice any significant delay by removing this, so I assume that
the previous delay was caused by a Jetty bug (back in 8.x) that is now
fixed in the Jetty version the Jenkins project uses.

Testing done

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

I added this line 10 years ago to address a start-up delay. However I
need now to remove it in order to allow configuration discovery.

I couldn't notice any significant delay by removing this, so I assume that
the previous delay was caused by a Jetty bug (back in 8.x) that is now
fixed in the Jetty version the Jenkins project uses.
@timja timja merged commit 36bbfda into jenkinsci:master Jan 31, 2025
5 checks passed
@Vlatombe Vlatombe deleted the web-fragments branch February 3, 2025 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants