Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ported dev window to bevy_editor_plz #175

Merged
merged 4 commits into from
Feb 20, 2023

Conversation

PhaestusFox
Copy link
Contributor

I saw issue #113 and decided to do it.
currently, this is more of a draft implementation since It is missing a key detail and there is at least one bug that should probably be fixed before a full merge.

I also made bevy_editor_pls open on q and not e so it doesn't open when you talk to the NPC

I don't know how to open a floating window outside of using the top bar with bevy_editor_plz so I removed the toggle code but this does mean you still get user input when the window is open.

there also is a bug that the menu will toggle from its open state when you close the escape menu, this would not be a problem if it only close when closing the menu but it will actually reopen it if you close it before hitting escape again. also only does it when closing the scape menu not opening it. I think this has to do with how you are telling egui to toggle the escape menu

hope this helps you get started since in the issue you were planning to do some sort of delayed update because you need multiple mutable world access but this doesn't seem to be the case.

@janhohenheim
Copy link
Owner

Thanks, I'll get on finishing the open points :)
Hehe, I see that the dialog and editor being on the same key is bothersome. The reason I never noticed is that I use the Workman keyboard layout and bevy_editor_pls doesn't use ScanCodes yet (jakobhellermann/bevy_editor_pls#62), so for me they aren't on the same key at all! 😄

@janhohenheim janhohenheim merged commit 86e5203 into janhohenheim:main Feb 20, 2023
@janhohenheim
Copy link
Owner

Update: I finished your work in #176; I quite like how it works now, thanks :)
I cannot reproduce the described interaction with the pause screen on my macOS. Can you confirm whether this still happens on main?

@PhaestusFox
Copy link
Contributor Author

the bug is definitely still there, I did some further testing and if you click the arrow it won't toggle till you click again or hit escape I have a video showing this off. I think this is probably a redraw issue, and hitting escape forces the redraw but I don't know how egui works at that level

2023-02-24_13-23-29.mov

@janhohenheim
Copy link
Owner

janhohenheim commented Feb 24, 2023

Oooh I see the problem, thanks for the video.
Yeah, that seems like a weird issue 😅 Opting to leave it for the moment since this looks like a rabbit hole to get into for a very minor bug.

janhohenheim added a commit that referenced this pull request Feb 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants