Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api/cli: introduce remote_config #9656

Closed
Tracked by #9296
efiop opened this issue Jun 23, 2023 · 2 comments · Fixed by #9788
Closed
Tracked by #9296

api/cli: introduce remote_config #9656

efiop opened this issue Jun 23, 2023 · 2 comments · Fixed by #9788
Assignees
Labels
A: api Related to the dvc.api feature request Requesting a new feature p1-important Important, aka current backlog of things to do

Comments

@efiop
Copy link
Contributor

efiop commented Jun 23, 2023

We already have config as the most powerful option, but remote_config would be convenient in most cases. As a start, it is fine to only make it set the default remote's config and not care about per-output remotes (one could use config if he needs to tweak that).

e.g. this will merge {"passphrase": "mypass"} with the default remote's config

with dvc.api.open(url, path, remote_config={"passphrase": "mypass"}):
....

this will set default remote to myremote and then merge {"passphrase": "mypass"} with myremotes remote's config

with dvc.api.open(url, path, remote="myremote", remote_config={"passphrase": "mypass"}):
....
@efiop efiop added feature request Requesting a new feature A: api Related to the dvc.api labels Jun 23, 2023
@efiop efiop self-assigned this Jun 26, 2023
@dberenbaum dberenbaum added the p1-important Important, aka current backlog of things to do label Jul 18, 2023
@dberenbaum dberenbaum added this to DVC Jul 18, 2023
@github-project-automation github-project-automation bot moved this to Backlog in DVC Jul 18, 2023
@dberenbaum dberenbaum moved this from Backlog to Todo in DVC Jul 18, 2023
@dberenbaum
Copy link
Collaborator

Let's use the same format as dvc exp run --set-param key=val

@efiop
Copy link
Contributor Author

efiop commented Jul 25, 2023

@dberenbaum You probably mean --remote-config for CLI, right? In api we can just pass a dict.

@efiop efiop changed the title api: introduce remote_config api/cli: introduce remote_config Aug 1, 2023
efiop added a commit to efiop/dvc that referenced this issue Aug 1, 2023
efiop added a commit to efiop/dvc that referenced this issue Aug 1, 2023
efiop added a commit to efiop/dvc that referenced this issue Aug 1, 2023
@github-project-automation github-project-automation bot moved this from Todo to Done in DVC Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: api Related to the dvc.api feature request Requesting a new feature p1-important Important, aka current backlog of things to do
Projects
No open projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants