-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
import/get: meta-issue #9296
Comments
For the record: Edited first (fixed) and third (need scmrepo mirrors) points. |
@aguschin Any details you can add about monorepo support? |
No @dberenbaum. I'll add something when I start implementing |
With regard to clone caching, do we want it to be configurable? I'm not sure having the caching as default behavior is ideal. Right now if you import/get with a specific branch or tag name, we make a shallow clone with only that specific branch or tag. If a user has a giant git repo (which seems likely in the monorepo case), it is probably going to be faster for DVC to always make a new temporary shallow clone that only contains the specific thing they want to import than it would be for us to mirror their entire monorepo once and then re-use that cached mirror for future imports. It seems to me that it would make more sense to have the caching be optional (and non-default). |
@pmrowla Though global caching might not imply mirroring. We have caching within the session already, maybe there is a way to just make that global as is so we cache those shallow clones in |
Moved caching clones to the bottom of the checklist. I think what @efiop suggested makes sense, but if it's overly complex and/or isn't likely to be a major performance improvement, we can skip this item. |
For the record: all main tasks are done now. |
This issue collects improvements needed for
dvc import/get
:dvc pull
fails after version aware import-url for non version aware s3 remote #8872dvc remote/config --config myconfig
p2/research issues for performance improvements:
The text was updated successfully, but these errors were encountered: