Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ls/import/get: introduce --remote and --remote-config #9788

Merged
merged 1 commit into from
Aug 2, 2023

Conversation

efiop
Copy link
Contributor

@efiop efiop commented Aug 1, 2023

Similar to how it is used in api. --remote is used to specify a new default remote to set, while --remote-config can amend that (or just old default if --remote not specified). Example:

dvc get URL path --remote-config "access_key_id=mykey" "secret_access_key=mysecretkey"

Fixes #9656

Docs will be in iterative/dvc.org#4722

@efiop efiop marked this pull request as draft August 1, 2023 23:08
@efiop efiop added the feature is a feature label Aug 1, 2023
@efiop efiop self-assigned this Aug 1, 2023
@codecov
Copy link

codecov bot commented Aug 1, 2023

Codecov Report

Patch coverage: 56.25% and project coverage change: -0.05% ⚠️

Comparison is base (5c2fd67) 90.46% compared to head (3061e36) 90.42%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9788      +/-   ##
==========================================
- Coverage   90.46%   90.42%   -0.05%     
==========================================
  Files         480      480              
  Lines       36615    36656      +41     
  Branches     5277     5285       +8     
==========================================
+ Hits        33125    33145      +20     
- Misses       2892     2906      +14     
- Partials      598      605       +7     
Files Changed Coverage Δ
dvc/repo/ls.py 94.87% <ø> (ø)
tests/unit/command/test_get.py 100.00% <ø> (ø)
tests/unit/command/test_imp.py 100.00% <ø> (ø)
dvc/repo/imp.py 26.31% <7.69%> (-45.12%) ⬇️
dvc/dependency/repo.py 87.01% <54.54%> (-5.53%) ⬇️
dvc/cli/utils.py 76.00% <69.23%> (-7.34%) ⬇️
dvc/commands/get.py 86.36% <100.00%> (+0.64%) ⬆️
dvc/commands/imp.py 82.35% <100.00%> (+1.10%) ⬆️
dvc/commands/ls/__init__.py 90.69% <100.00%> (+0.45%) ⬆️
dvc/repo/get.py 92.59% <100.00%> (ø)
... and 1 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@efiop efiop marked this pull request as ready for review August 2, 2023 01:18
@efiop efiop merged commit b235487 into iterative:main Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature is a feature
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

api/cli: introduce remote_config
1 participant