fix(web): unable to download live photo as anonymous user #16455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alextran1502
approved these changes
Mar 1, 2025
knechtandreas
added a commit
to knechtandreas/immich
that referenced
this pull request
Mar 2, 2025
…n-grid * main: (22 commits) feat: add album keyboard shortcuts (immich-app#16442) fix(web): Default to context search on web (immich-app#16485) fix(mobile): Updated formatting of server address in networking (immich-app#16483) chore(mobile): rename log enum to lowercase (immich-app#16476) fix(web): Open huggingface.co link on settings page in new tab (immich-app#16470) fix(web): fix typos (immich-app#16466) fix(web): Fixed people list overflowing in advanced search (immich-app#16457) fix(web): unable to download live photo as anonymous user (immich-app#16455) fix(mobile): fix typos (immich-app#16456) chore: add 'not duplicate' checkbox to issue template (immich-app#16462) chore(mobile): post release task (immich-app#16437) feat(server): Shortened asset ID in storage template (immich-app#16433) chore: version v1.128.0 fix: memories off by one (immich-app#16434) fix(server): stringify error log parameter to ensure correct overload (immich-app#16422) fix: duplicate memories (immich-app#16432) chore(server): trash e2e cleanup (immich-app#16423) fix(server): include deleted assets if searching offline assets (immich-app#16417) fix: user delete sync query sort by id (immich-app#16420) fix(mobile): background backup failing due to store (immich-app#16418) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As described in the bug report,
get(preferences)returnsundefinedif the user is not logged in (from a shared album/image link for example). As such, it is impossible to download a live photo in this case: thedownloadFilefunction throws an error instead.Fixes #15836
(Note that I'm a C++/desktop developer, so I'm in unknown territory here 😅 But the change should be simple enough...)
How Has This Been Tested?
Manually tested in these conditions:
includeEmbeddedVideosoption enabledincludeEmbeddedVideosoption disabledChecklist:
src/servicesuses repositories implementations for database calls, filesystem operations, etc.src/repositories/is pretty basic/simple and does not have any immich specific logic (that belongs insrc/services)