Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mobile): background backup failing due to store #16418

Merged
merged 1 commit into from
Feb 28, 2025

Conversation

shenlong-tanwen
Copy link
Member

Description

HttpOveride is performed before the Store is initiated in the background service, resulting in background upload not working. We already override them again in the callback handler, hence the redundant override is removed.

@alextran1502 alextran1502 merged commit 9a98712 into main Feb 28, 2025
46 checks passed
@alextran1502 alextran1502 deleted the fix/store-background-backup branch February 28, 2025 13:38
@thegabriele97
Copy link

Does this fix #16416 ?

ExceptionsOccur pushed a commit to ExceptionsOccur/immich that referenced this pull request Feb 28, 2025
fix: background backup failing due to store

Co-authored-by: shenlong-tanwen <139912620+shalong-tanwen@users.noreply.github.com>
knechtandreas added a commit to knechtandreas/immich that referenced this pull request Mar 2, 2025
…n-grid

* main: (22 commits)
  feat: add album keyboard shortcuts (immich-app#16442)
  fix(web): Default to context search on web (immich-app#16485)
  fix(mobile): Updated formatting of server address in networking (immich-app#16483)
  chore(mobile): rename log enum to lowercase (immich-app#16476)
  fix(web): Open huggingface.co link on settings page in new tab (immich-app#16470)
  fix(web): fix typos (immich-app#16466)
  fix(web): Fixed people list overflowing in advanced search (immich-app#16457)
  fix(web): unable to download live photo as anonymous user (immich-app#16455)
  fix(mobile): fix typos (immich-app#16456)
  chore: add 'not duplicate' checkbox to issue template (immich-app#16462)
  chore(mobile): post release task (immich-app#16437)
  feat(server): Shortened asset ID in storage template (immich-app#16433)
  chore: version v1.128.0
  fix: memories off by one (immich-app#16434)
  fix(server): stringify error log parameter to ensure correct overload (immich-app#16422)
  fix: duplicate memories (immich-app#16432)
  chore(server): trash e2e cleanup (immich-app#16423)
  fix(server): include deleted assets if searching offline assets (immich-app#16417)
  fix: user delete sync query sort by id (immich-app#16420)
  fix(mobile): background backup failing due to store (immich-app#16418)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants