Clarify install of docker #7678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated description of installation to avoid possible confusion regarding docker as a dependency.
2 tasks
|
@magnusoverli In general I approve, maybe we need to clarify a little bit more on this being a method/example on installing Ubuntu specifically? |
Underlining Ubuntu as the tested environment for the given instructions.
Removed step from hass.io installation instructions wherein installing docker. Installation of Docker-CE is already documented.
frenck
approved these changes
Dec 26, 2018
|
Thanks, @magnusoverli! 👍 |
ludeeus
reviewed
Dec 26, 2018
| - jq | ||
| - network-manager | ||
| - socat | ||
| - software-properties-common | ||
|
|
||
| To perform the Hass.io installation, run the following command as root: | ||
| You also need to have Docker-CE installed. There is well-documented procedures for installing Docker on Ubuntu at [Docker.com](https://docs.docker.com/install/linux/docker-ce/ubuntu/). |
There was a problem hiding this comment.
This could confuse some users (to think that only ubuntu are supported)
Suggested change
| You also need to have Docker-CE installed. There is well-documented procedures for installing Docker on Ubuntu at [Docker.com](https://docs.docker.com/install/linux/docker-ce/ubuntu/). | |
| You also need to have Docker-CE installed. There are well-documented procedures for installing Docker at [Docker.com](https://docs.docker.com/install/), you can find installation steps for your distro in the menu on the left. |
I suggest changing the link to be more generic.
alengwenus
pushed a commit
to alengwenus/home-assistant.io
that referenced
this pull request
Feb 24, 2019
* Clarify install of docker Updated description of installation to avoid possible confusion regarding docker as a dependency. * Details on tested environment Underlining Ubuntu as the tested environment for the given instructions. * Removed redundant docker install step Removed step from hass.io installation instructions wherein installing docker. Installation of Docker-CE is already documented. * ✏️ Tweaks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated description of installation to avoid possible confusion regarding docker as a dependency.
Description:
Pull request in home-assistant (if applicable): home-assistant/home-assistant#
Checklist:
nextis for changes and new documentation that will go public with the next home-assistant release. Fixes, changes and adjustments for the current release should be created againstcurrent.