Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update list of dependencies #7672

Merged
merged 1 commit into from
Nov 28, 2018
Merged

Update list of dependencies #7672

merged 1 commit into from
Nov 28, 2018

Conversation

magnusoverli
Copy link
Contributor

@magnusoverli magnusoverli commented Nov 28, 2018

Add docker to the list of dependencies

Description:

Pull request in home-assistant (if applicable): home-assistant/home-assistant#

Checklist:

  • Branch: next is for changes and new documentation that will go public with the next home-assistant release. Fixes, changes and adjustments for the current release should be created against current.
  • The documentation follows the standards.

Add docker to the list of dependencies
@ghost ghost added the to-do label Nov 28, 2018
Copy link
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🐦

@fabaff fabaff merged commit af53ce0 into home-assistant:current Nov 28, 2018
@ghost ghost removed the to-do label Nov 28, 2018
@magnusoverli magnusoverli deleted the patch-2 branch November 28, 2018 18:45
@frenck
Copy link
Member

frenck commented Nov 28, 2018

@magnusoverli This is confusing and a risky change.
Reasoning, please might install the Docker that came with their OS distribution, which is a really bad idea...

@frenck frenck added enhancement current This PR goes into the current branch labels Nov 28, 2018
@magnusoverli
Copy link
Contributor Author

Suggested fix in #7678.

@fabaff
Copy link
Member

fabaff commented Nov 29, 2018

It's just a list of deps. We don't say how to install it. It's an advance method and really depends on the underlying OS.

@magnusoverli
Copy link
Contributor Author

In that case, specifying Docker-CE should be enough?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
current This PR goes into the current branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants