Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reverts #7945 #7948

Merged
merged 1 commit into from
Dec 26, 2018
Merged

Reverts #7945 #7948

merged 1 commit into from
Dec 26, 2018

Conversation

frenck
Copy link
Member

@frenck frenck commented Dec 25, 2018 •
edited
Loading

Description:

Reverts PR #7945

Using the Docker.io version will cause issues, hence it was removed before.
You need to install Docker CE, even though not provided by each OS directly.

Pull request in home-assistant (if applicable): home-assistant/home-assistant#

Checklist:

  • Branch: next is for changes and new documentation that will go public with the next home-assistant release. Fixes, changes and adjustments for the current release should be created against current.
  • The documentation follows the standards.

@frenck frenck added bug This issue or PR is related to an unexpected behavoir on our website/documentation ready-for-review This PR needs to be reviewed current This PR goes into the current branch labels Dec 25, 2018
@ghost ghost assigned frenck Dec 25, 2018
@frenck frenck mentioned this pull request Dec 25, 2018
Merged
2 tasks
@fabaff
Copy link
Member

fabaff commented Dec 25, 2018

If docker.io is not working then should this be mentioned. Putting docker in list of packages which are required on Debian/Ubuntu will give one the wrong package no matter what.

@frenck
Copy link
Member Author

frenck commented Dec 26, 2018

@fabaff There is a PR open for that, which I will look at today.

ludeeus
ludeeus approved these changes Dec 26, 2018
View reviewed changes
Copy link
Member

@ludeeus ludeeus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@ludeeus ludeeus merged commit 63405cc into current Dec 26, 2018
@ghost ghost removed the ready-for-review This PR needs to be reviewed label Dec 26, 2018
@delete-merged-branch delete-merged-branch bot deleted the revert-docker-io branch December 26, 2018 12:51
@frenck
Copy link
Member Author

frenck commented Dec 26, 2018

@fabaff Tuned, #7678. That should fix the issues.

@almostengr
Copy link
Contributor

Docker-ce was not mentioned as one of the dependencies. If it is truly one, it should be listed and how to install it should also be included.
For my installation, docker.io worked.
The install script complained that docker wasn't installed until I installed docker.io.

@ludeeus
Copy link
Member

ludeeus commented Dec 26, 2018

@almostengr the changes implemented in #7678 should take care of that.

alengwenus pushed a commit to alengwenus/home-assistant.io that referenced this pull request Feb 24, 2019
@frenck @alengwenus
🚑 Reverts home-assistant#7945 (home-assistant#7948)
cf25c2e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ludeeus ludeeus ludeeus approved these changes

Assignees

@frenck frenck

Labels
bug This issue or PR is related to an unexpected behavoir on our website/documentation current This PR goes into the current branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@frenck @fabaff @almostengr @ludeeus