hassfest: Unable to parse package version when requirement contains git

[mill1000]

I'm attempting to run hassfest against a custom component that currently uses a git repository as a requirement. I'm using the format specified by the docs here.

e.g.

"requirements": ["git+https://github.com/mill1000/midea-msmart.git"],

hassfest is failing with the following error:

Error: R] [REQUIREMENTS] Unable to parse package version (+https://github.com/mill1000/midea-msmart.git) for git.

[rytilahti]

Related to home-assistant/developers.home-assistant#2125

[andyb2000]

This appears to still be an issue, however based o the updated docs

{
  "requirements": ["<project> @ git+https://github.com/<user>/<project>.git@<git ref>"]
}

hassfest errors out with Error: R] [REQUIREMENTS] Requirement ...blah... contains a space

It seems to be failing due to the SPACE@SPACE
Is this a fault in hassfest or hass? @ludeeus is this something you're aware of?

[mpw96]

Components that declare a requirement as stated above do work as expected. It seems that just the hassfest test is not aware of this format.

[andyb2000]

Hi @mpw96 perhaps you can help/clarify.

This still doesn't seem to be working.
In my manifest.json:

{
  "domain": "husqvarna_automower_ble",
  "name": "Husqvarna Automower BLE",
  "bluetooth": [
    {
      "connectable": true,
      "service_uuid": "98bd0001-0b0e-421a-84e5-ddbf75dc6de4"
    }
  ],
  "codeowners": ["@alistair23", "@andyb2000"],
  "config_flow": true,
  "dependencies": ["bluetooth_adapters"],
  "documentation": "https://github.com/andyb2000/HACS-husqvarna_automower_ble/",
  "iot_class": "local_polling",
  "issue_tracker": "https://github.com/andyb2000/HACS-husqvarna_automower_ble/issues",
  "requirements": ["automower_ble @ git+https://github.com/alistair23/AutoMower-BLE.git@main"],
  "version": "0.1.1"
}

This is still rejected by hassfest@master with the error:

Integration husqvarna_automower_ble - /github/workspace/custom_components/husqvarna_automower_ble:
Error: R] [REQUIREMENTS] Requirement "automower_ble @ git+https://github.com/alistair23/AutoMower-BLE.git@main" contains a space

Error: Process completed with exit code 1.

Which is still how the documentation at https://developers.home-assistant.io/docs/creating_integration_manifest/#custom-requirements-during-development--testing specifies we reference public github repo's for requirements.

"requirements": [" @ git+https://github.com//.git@"]

Is the documentation wrong or is hassfest validation wrong?

[mpw96]

Hi I just wanted hassfest in my component not to cmplain anymore, that's why I proposed the change - I hope I didn't make things worse for anybody! Here is what works for me:

  "requirements": [
    "git+https://github.com/mpw96/goecharger.git@0.1.1"
  ],

So your code should be like this I think:

...
"requirements": ["git+https://github.com/alistair23/AutoMower-BLE.git@main"],
...

Does it work?

[mpw96]

So what @mill1000 needs should actually work now.

[mill1000]

I ran a test here and it seems to be working: mill1000/midea-ac-py#268

[andyb2000]

"requirements": ["git+https://github.com/alistair23/AutoMower-BLE.git@main"],

thanks, yes using this formatting now works, I'll put a PR in to update documentation as I think that will still be throwing people off.

Thanks all :)