-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update creating_integration_manifest.md #2125
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hassfest doesn't seem to agree, are you sure this is correct syntax?
I tried it successfully like this: I did not not look carefully the original text about the hash refrence. It does not seem valid for Now having a second look at the syntax it should be @rytilahti your example error complains So your case might be I will fix the PR. |
e1ba5da
to
e4171a9
Compare
|
So what mine tries to do is to install the master branch unless version 0.6.0 is available/installed. I couldn't find any reference for this in the pypa/pip docs, so I'm not sure if it ever worked as described in the current docs. Anyway, I just tried the exact string you gave on the current
edit: If a git url is defined, the dependency will always be downloaded from git so my logic was wrong. Still unsure why I'm getting the "contains a space" error and how it should be fixed. |
I think so too. That is not a valid reference for Git, nor the semantics how it is stated to work. (It might work with Subversion version control?)
My environment where it works is:
|
Fix the syntax in the example of the requirement pointing to a public GitHub repository .
Rebased |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @sofkaski 👍
Fix the syntax in the example of the requirement pointing to a public GitHub repository .
Proposed change
Fix the syntax in the example of the requirement pointing to a public GitHub repository and add explanation of the version.
Type of change
Additional information