-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add quality scale #92
Conversation
|
||
# Platinum 🎖 | ||
|
||
Best of the best. The integration is completely async, meaning it's super fast. Integrations that reach expert level will require the code owner approval for each PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Integrations that reach platinum level will require approval by the code owner for each new PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this also require some SLA from the owner?
7027654
to
4cc861f
Compare
Addressed comments. Also updated the emoji for the platinum level 😉 |
sidebar_label: "Introduction" | ||
--- | ||
|
||
The Integration Quality Scale scores each integration based on the code quality and user experience. Each level of the quality scale consists of a list of requirements. t If an integration matches all requirements, it's considered to have reached that level. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"t" remove it.
This is a solid integration that is able to survive poor conditions and can be configured via the user interface. | ||
|
||
- Configurable via config entries. | ||
- Don't allow configuring already configired device/service (example: no 2 entries for same hub) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
configired -> configured
|
||
# Platinum 🏆 | ||
|
||
Best of the best. The integration is completely async, meaning it's super fast. Integrations that reach platinum level will require approval by the code owner for each PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Potentially we'll get stale PRs that are waiting for approval by code owner who's gone in hiding.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In that case we can downgrade a component to Gold and unblock the PRs.
Going to merge this now. This is not the end of the discussion, but the beginning. Now we have something we can iterate upon. |
…nal git library As in issue home-assistant#92 (home-assistant/actions#92) this update to documentation corrects this in line with hassfest validation.
As in issue #92 (home-assistant/actions#92) this update to documentation corrects this in line with hassfest validation.
Preview page: https://deploy-preview-92--developers-home-assistant.netlify.com/docs/en/next/integration_quality_scale_index.html
Fixes home-assistant/architecture#20