Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add quality scale #92

Merged
merged 8 commits into from
Sep 26, 2018
Merged

Add quality scale #92

merged 8 commits into from
Sep 26, 2018

Conversation

balloob
Copy link
Member

@balloob balloob commented Sep 25, 2018


# Platinum 🎖

Best of the best. The integration is completely async, meaning it's super fast. Integrations that reach expert level will require the code owner approval for each PR.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Integrations that reach platinum level will require approval by the code owner for each new PR.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this also require some SLA from the owner?

@balloob
Copy link
Member Author

balloob commented Sep 26, 2018

Addressed comments. Also updated the emoji for the platinum level 😉

sidebar_label: "Introduction"
---

The Integration Quality Scale scores each integration based on the code quality and user experience. Each level of the quality scale consists of a list of requirements. t If an integration matches all requirements, it's considered to have reached that level.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"t" remove it.

This is a solid integration that is able to survive poor conditions and can be configured via the user interface.

- Configurable via config entries.
- Don't allow configuring already configired device/service (example: no 2 entries for same hub)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

configired -> configured


# Platinum 🏆

Best of the best. The integration is completely async, meaning it's super fast. Integrations that reach platinum level will require approval by the code owner for each PR.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Potentially we'll get stale PRs that are waiting for approval by code owner who's gone in hiding.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In that case we can downgrade a component to Gold and unblock the PRs.

@balloob
Copy link
Member Author

balloob commented Sep 26, 2018

Going to merge this now. This is not the end of the discussion, but the beginning. Now we have something we can iterate upon.

@balloob balloob merged commit e4ab6fd into master Sep 26, 2018
@balloob balloob deleted the add-quality-scale branch September 26, 2018 12:31
andyb2000 added a commit to andyb2000/developers.home-assistant that referenced this pull request Nov 4, 2024
…nal git library

As in issue home-assistant#92 (home-assistant/actions#92) this update to documentation corrects this in line with hassfest validation.
MartinHjelmare pushed a commit that referenced this pull request Nov 4, 2024
As in issue #92 (home-assistant/actions#92) this update to documentation corrects this in line with hassfest validation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants