Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support configurable port and consider a default port other than 80 #325

Closed
LukeBair opened this issue Feb 2, 2025 · 0 comments · Fixed by #330
Closed

Support configurable port and consider a default port other than 80 #325

LukeBair opened this issue Feb 2, 2025 · 0 comments · Fixed by #330
Assignees
@LukeBair
Labels
enhancement New feature or request
Milestone
Sprint 17

Comments

@LukeBair
Copy link
Contributor

LukeBair commented Feb 2, 2025 •
edited
Loading

The TCK looks for a JSON-RPC server on localhost port 80. Port 80 is problematic because you need to run as super-user, which is awkward. It would be better to pick a port above 1024, such as 8545 (This should be the default JSON-RPC server port). Both the host and port of the JSON-RPC server should be trivially configurable on the TCK, to support scenarios where the TCK is on one machine and the JSON-RPC server on another. The project should also document which port is the default port so that all SDKs can use the correct port by default.
LukeBair added a commit to LukeBair/hiero-sdk-tck that referenced this issue Feb 6, 2025
@LukeBair
configurable json-rpc-server url + lint errors
9349d07 
this commit fixes issue hiero-ledger#325
Signed-off-by: LukeBair <74842241+LukeBair@users.noreply.github.com>
@LukeBair LukeBair mentioned this issue Feb 6, 2025
Merged
@rbair23 rbair23 linked a pull request Feb 6, 2025 that will close this issue
support for custom json-rpc-server urls #330
Merged
@rwalworth rwalworth added the enhancement New feature or request label Feb 6, 2025
@rwalworth rwalworth added this to the Sprint 17 milestone Feb 6, 2025
LukeBair added a commit to LukeBair/hiero-sdk-tck that referenced this issue Feb 6, 2025
@LukeBair
Added a configurable json-rpc-server url
f7ee231 
Added a line talking about the default json rpc server url, and where it can be configured in the README

this commit fixes issue hiero-ledger#325
Signed-off-by: LukeBair <74842241+LukeBair@users.noreply.github.com>
This was referenced Feb 6, 2025
Closed
Closed
Open
Open
Open
Open
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LukeBair LukeBair

Labels
enhancement New feature or request
Projects
None yet
Milestone
Sprint 17
Development

Successfully merging a pull request may close this issue.

support for custom json-rpc-server urls LukeBair/hiero-sdk-tck
2 participants
@LukeBair @rwalworth