support for custom json-rpc-server urls #330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbair23
approved these changes
Feb 6, 2025
|
@rwalworth Of course! I'm not sure if this last commit added enough information to the readme, if there should be more I can add some more. |
Added a line talking about the default json rpc server url, and where it can be configured in the README this commit fixes issue hiero-ledger#325 Signed-off-by: LukeBair <74842241+LukeBair@users.noreply.github.com>
daec05a to
f7ee231
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new environment variable: "JSON_RPC_SERVER_URL" which defaults to "http://localhost:8545/" which is the normal json rpc server port. Also made sure that Client.ts defaults to the same url when no environment variable is found.
This fixes issue #325