Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default port already in use by local-node and solo mirror node #332

Closed
rwalworth opened this issue Feb 7, 2025 · 2 comments
Closed

Default port already in use by local-node and solo mirror node #332

rwalworth opened this issue Feb 7, 2025 · 2 comments
Assignees
@rwalworth
Labels
Bug A error that causes the feature to behave differently than what was expected based on design docs
Milestone
Sprint 18

Comments

@rwalworth
Copy link
Contributor

rwalworth commented Feb 7, 2025 •
edited
Loading

#325 changed the default port of the TCK to 8545. However, this port is used by local-node and solo mirror node. Instead of having to overwrite the default for our standard testing setup, I think it'd be better to just change the default port to something that works.
@rwalworth rwalworth self-assigned this Feb 7, 2025
@rwalworth rwalworth added the Bug A error that causes the feature to behave differently than what was expected based on design docs label Feb 7, 2025
@rwalworth rwalworth added this to the Sprint 17 milestone Feb 7, 2025
@rwalworth
Copy link
Contributor Author

rwalworth commented Feb 7, 2025 •
edited
Loading

@LukeBair any additional insights here? I know 8545 was chosen because it's the default JSON-RPC port. I didn't realize 8545 was already in use, would you be fine with 8544?

@rwalworth rwalworth changed the title Change default port to 8546 Default port already in use by local-node and solo mirror node Feb 7, 2025
@rwalworth rwalworth modified the milestones: Sprint 17, Sprint 18 Feb 18, 2025
@rwalworth
Copy link
Contributor Author

Fixed in #329.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rwalworth rwalworth

Labels
Bug A error that causes the feature to behave differently than what was expected based on design docs
Projects
None yet
Milestone
Sprint 18
Development

When branches are created from issues, their pull requests are automatically linked.

refs/heads/00332-change-default-port-to-8546 hiero-ledger/hiero-sdk-tck
1 participant
@rwalworth