-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run tests with Github Actions #61
Conversation
Github Actions test workflow is now working and picking up build errors because mongodb dependencies introduced by #53 are not vendored:
https://github.com/pdecat/go-pagerduty/runs/3430412065?check_suite_focus=true#step:4:17 Also, what about switching from govendor to go modules to manage dependencies? |
- name: Checkout | ||
uses: actions/checkout@v2 | ||
with: | ||
path: src/github.com/heimweh/go-pagerduty/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See actions/setup-go#102 (comment) for why this is needed.
145ddd0
to
569cbdf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @pdecat! This looks great 🎉
Let's merge this one and switch to go modules while we're at it so we can fix the dep issues 👍
* Run tests with Github Actions * Fix Github Actions test workflow by setting GOPATH
This PR adds support for running tests with Github Actions as the Travis CI job does not seem to be enabled.