-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ServicePayload
to remove nested Service
attribute from Service
struct
#58
Conversation
08451cf
to
86e196a
Compare
Totally agree with this change. This is how we design resources today. Just one ask before approving. Will you also fix the
|
Nice job @pdecat! Really appreciate it! Been wanting to tackle this for some time now 😅 |
86e196a
to
9511f75
Compare
Fixed the tests:
|
Submitted #61 to enable Github Actions to run them automatically. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Thank you!! 🎉
9511f75
to
c3f4857
Compare
This PR resolves #57