Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pagerduty: cleanup of remaining structs #63

Merged
merged 1 commit into from
Sep 18, 2021
Merged

pagerduty: cleanup of remaining structs #63

merged 1 commit into from
Sep 18, 2021

Conversation

heimweh
Copy link
Owner

@heimweh heimweh commented Sep 17, 2021

Attempt to remove the nested structs in most/if not all remaining places, replacing them with payload structs.

Related:

stmcallister
stmcallister approved these changes Sep 17, 2021
View reviewed changes
Copy link
Collaborator

@stmcallister stmcallister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done! 🎉 Thank you!!!

@heimweh heimweh merged commit a01d951 into master Sep 18, 2021
@heimweh heimweh deleted the ah/payload branch September 18, 2021 03:58
stmcallister pushed a commit that referenced this pull request Oct 21, 2021
@heimweh
pagerduty/addon: remove nested addon from struct (#63)
86253c4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stmcallister stmcallister stmcallister approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@heimweh @stmcallister