Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vendor missing dependencies with govendor add +external #62

Closed
wants to merge 1 commit into from

Conversation

pdecat
Copy link
Contributor

@pdecat pdecat commented Aug 26, 2021

This PR adds the mongodb dependencies introduced by #53 that are not vendored:

pagerduty/cache.go:13:2: cannot find package "go.mongodb.org/mongo-driver/bson" in any of:
	/home/runner/work/go-pagerduty/go-pagerduty/src/github.com/heimweh/go-pagerduty/vendor/go.mongodb.org/mongo-driver/bson (vendor tree)
	/opt/hostedtoolcache/go/1.16.7/x64/src/go.mongodb.org/mongo-driver/bson (from $GOROOT)
	/home/runner/work/go-pagerduty/go-pagerduty/src/go.mongodb.org/mongo-driver/bson (from $GOPATH)
pagerduty/cache.go:14:2: cannot find package "go.mongodb.org/mongo-driver/bson/primitive" in any of:
	/home/runner/work/go-pagerduty/go-pagerduty/src/github.com/heimweh/go-pagerduty/vendor/go.mongodb.org/mongo-driver/bson/primitive (vendor tree)
	/opt/hostedtoolcache/go/1.16.7/x64/src/go.mongodb.org/mongo-driver/bson/primitive (from $GOROOT)
	/home/runner/work/go-pagerduty/go-pagerduty/src/go.mongodb.org/mongo-driver/bson/primitive (from $GOPATH)
pagerduty/cache.go:15:2: cannot find package "go.mongodb.org/mongo-driver/mongo" in any of:
	/home/runner/work/go-pagerduty/go-pagerduty/src/github.com/heimweh/go-pagerduty/vendor/go.mongodb.org/mongo-driver/mongo (vendor tree)
	/opt/hostedtoolcache/go/1.16.7/x64/src/go.mongodb.org/mongo-driver/mongo (from $GOROOT)
	/home/runner/work/go-pagerduty/go-pagerduty/src/go.mongodb.org/mongo-driver/mongo (from $GOPATH)
pagerduty/cache.go:16:2: cannot find package "go.mongodb.org/mongo-driver/mongo/options" in any of:
	/home/runner/work/go-pagerduty/go-pagerduty/src/github.com/heimweh/go-pagerduty/vendor/go.mongodb.org/mongo-driver/mongo/options (vendor tree)
	/opt/hostedtoolcache/go/1.16.7/x64/src/go.mongodb.org/mongo-driver/mongo/options (from $GOROOT)
	/home/runner/work/go-pagerduty/go-pagerduty/src/go.mongodb.org/mongo-driver/mongo/options (from $GOPATH)
pagerduty/cache.go:17:2: cannot find package "go.mongodb.org/mongo-driver/mongo/readpref" in any of:
	/home/runner/work/go-pagerduty/go-pagerduty/src/github.com/heimweh/go-pagerduty/vendor/go.mongodb.org/mongo-driver/mongo/readpref (vendor tree)
	/opt/hostedtoolcache/go/1.16.7/x64/src/go.mongodb.org/mongo-driver/mongo/readpref (from $GOROOT)
	/home/runner/work/go-pagerduty/go-pagerduty/src/go.mongodb.org/mongo-driver/mongo/readpref (from $GOPATH)

Also, what about switching from govendor to go modules to manage dependencies?

@pdecat
Copy link
Contributor Author

pdecat commented Sep 18, 2021

No longer needed since switch to go modules.

@pdecat pdecat closed this Sep 18, 2021
@pdecat pdecat deleted the vendor_mongodb branch September 18, 2021 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant