Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: avoid considering output panes as editors #771

Merged
merged 2 commits into from
Sep 16, 2021
Merged

fix: avoid considering output panes as editors #771

merged 2 commits into from
Sep 16, 2021

Conversation

radeksimko
Copy link
Member

Fixes #744

Before

2021-09-14 18 46 47

After

2021-09-14 18 44 57

@radeksimko radeksimko added the bug Something isn't working label Sep 14, 2021
@radeksimko radeksimko requested a review from a team September 14, 2021 17:47
This was referenced Sep 15, 2021
Merged
Merged
@radeksimko radeksimko force-pushed the b-avoid-irrelevant-editors branch from cdfc81f to 80cfbd6 Compare September 16, 2021 16:52
@radeksimko radeksimko requested a review from jpogran September 16, 2021 16:53
jpogran
jpogran approved these changes Sep 16, 2021
View reviewed changes
Copy link
Contributor

@jpogran jpogran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything is an editor didn't ya know

@radeksimko radeksimko merged commit 9b28561 into main Sep 16, 2021
@radeksimko radeksimko deleted the b-avoid-irrelevant-editors branch September 16, 2021 17:04
jpogran added a commit that referenced this pull request Sep 16, 2021
@jpogran
incorporate #771 approach
0813847
jpogran added a commit that referenced this pull request Sep 17, 2021
@jpogran
incorporate #771 approach
70c16bf
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jpogran jpogran jpogran approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

URI "output:extension-output-hashicorp.terraform-%231" is not valid
2 participants
@radeksimko @jpogran