URI "output:extension-output-hashicorp.terraform-%231" is not valid

[ToniCipriani]

Versions

This bug is reproducible in:

• the latest version of the extension (below)
• the latest version of the language server (below)

Extension

Released on
2/12/2016, 03:31:09
Last updated
7/22/2021, 10:24:21
Identifier
hashicorp.terraform

Language Server

Output too large, see attached

terraform-ls-debug.out.tar.gz

VS Code

Version: 1.59.1
Commit: 3866c3553be8b268c8a7f8c0482c0c0177aa8bfa
Date: 2021-08-19T11:53:52.479Z (1 wk ago)
Electron: 13.1.7
Chrome: 91.0.4472.124
Node.js: 14.16.0
V8: 9.1.269.36-electron.0
OS: Darwin x64 19.6.0

Operating System

OS X Catalina 10.15.7
Darwin (redacted) 19.6.0 Darwin Kernel Version 19.6.0: Tue Jun 22 19:49:55 PDT 2021; root:xnu-6153.141.35~1/RELEASE_X86_64 x86_64

Terraform Version

Terraform v0.15.3
on darwin_amd64

Steps To Reproduce

[radeksimko]

Just found the root cause. It appears that VS Code consideres Output panes as active text editor areas too microsoft/vscode#58869

Which means that if you click/focus on the Output pane and then either the background command runs, or you execute any command yourself (formatting, init, ...) with that pane in focus then we receive URI for that pane, instead of the actual editor tab.

We just need to find a better (more reliable and accurate) way of obtaining the relevant/open file or directory URI...

[radeksimko]

I think the best way forward would be looping over window.visibleTextEditors and looking for an editor which has viewColumn == Active https://code.visualstudio.com/api/references/vscode-api#ViewColumn and relatedly use vscode.window.onDidChangeVisibleTextEditors callback instead of onDidChangeActiveTextEditor.

I will work on a patch.

[github-actions]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.