fix: avoid considering output panes as editors

src/clientHandler.ts

@@ -281,6 +281,11 @@ export class ClientHandler {
     return clients.get(this.clientName(document.toString()));
   }
 
+  public clientSupportsCommand(cmdName: string, document?: vscode.Uri): boolean {
+    const commands = this.getClient(document).client.initializeResult.capabilities.executeCommandProvider?.commands;
+    return commands.includes(cmdName);
+  }
+
   private clientName(folderName: string, workspaceFolders: readonly string[] = sortedWorkspaceFolders()): string {
     folderName = normalizeFolderName(folderName);
     const outerFolder = workspaceFolders.find((element) => folderName.startsWith(element));

src/extension.ts

@@ -7,7 +7,7 @@ import { ClientHandler, TerraformLanguageClient } from './clientHandler';
 import { defaultVersionString, isValidVersionString, LanguageServerInstaller } from './languageServerInstaller';
 import { ServerPath } from './serverPath';
 import { SingleInstanceTimeout } from './utils';
-import { config, prunedFolderNames } from './vscodeUtils';
+import { config, getActiveTextEditor, prunedFolderNames } from './vscodeUtils';
 
 const terraformStatus = vscode.window.createStatusBarItem(vscode.StatusBarAlignment.Left, 0);
 
@@ -121,35 +121,9 @@ export async function activate(context: vscode.ExtensionContext): Promise<any> {
         await clientHandler.startClients(prunedFolderNames(event.added));
       }
     }),
-    vscode.window.onDidChangeActiveTextEditor(async (event: vscode.TextEditor | undefined) => {
-      // Make sure there's an open document in a folder
-      // Also check whether they're running a different language server
-      // TODO: Check initializationOptions for command presence instead of pathToBinary
-      if (event && vscode.workspace.workspaceFolders[0] && !lsPath.hasCustomBinPath()) {
-        const documentUri = event.document.uri;
-        const client = clientHandler.getClient(documentUri);
-        const moduleUri = Utils.dirname(documentUri);
-
-        if (client) {
-          try {
-            const response = await moduleCallers(client, moduleUri.toString());
-            if (response.moduleCallers.length === 0) {
-              const dirName = Utils.basename(moduleUri);
-              terraformStatus.text = `$(refresh) ${dirName}`;
-              terraformStatus.color = new vscode.ThemeColor('statusBar.foreground');
-              terraformStatus.tooltip = `Click to run terraform init`;
-              terraformStatus.command = 'terraform.initCurrent';
-              terraformStatus.show();
-            } else {
-              terraformStatus.hide();
-            }
-          } catch (err) {
-            vscode.window.showErrorMessage(err);
-            reporter.sendTelemetryException(err);
-            terraformStatus.hide();
-          }
-        }
-      }
+    vscode.window.onDidChangeVisibleTextEditors(async () => {
+      const textEditor = getActiveTextEditor();
+      await updateTerraformStatusBar(textEditor.document.uri);
     }),
   );
 
@@ -169,6 +143,34 @@ export function deactivate(): Promise<void[]> {
   return clientHandler.stopClients();
 }
 
+async function updateTerraformStatusBar(documentUri: vscode.Uri) {
+  const initSupported = clientHandler.clientSupportsCommand('terraform-ls.terraform.init', documentUri);
+  if (initSupported) {
+    const client = clientHandler.getClient(documentUri);
+    const moduleUri = Utils.dirname(documentUri);
+
+    if (client) {
+      try {
+        const response = await moduleCallers(client, moduleUri.toString());
+        if (response.moduleCallers.length === 0) {
+          const dirName = Utils.basename(moduleUri);
+          terraformStatus.text = `$(refresh) ${dirName}`;
+          terraformStatus.color = new vscode.ThemeColor('statusBar.foreground');
+          terraformStatus.tooltip = `Click to run terraform init`;
+          terraformStatus.command = 'terraform.initCurrent';
+          terraformStatus.show();
+        } else {
+          terraformStatus.hide();
+        }
+      } catch (err) {
+        vscode.window.showErrorMessage(err);
+        reporter.sendTelemetryException(err);
+        terraformStatus.hide();
+      }
+    }
+  }
+}
+
 async function updateLanguageServer(clientHandler: ClientHandler, lsPath: ServerPath) {
   console.log('Checking for language server updates...');
   const hour = 1000 * 60 * 60;
@@ -241,11 +243,11 @@ async function terraformCommand(
   languageServerExec = true,
   clientHandler: ClientHandler,
 ): Promise<any> {
-  if (vscode.window.activeTextEditor) {
-    const documentUri = vscode.window.activeTextEditor.document.uri;
-    const languageClient = clientHandler.getClient(documentUri);
+  const textEditor = getActiveTextEditor();
+  if (textEditor) {
+    const languageClient = clientHandler.getClient(textEditor.document.uri);
 
-    const moduleUri = Utils.dirname(documentUri);
+    const moduleUri = Utils.dirname(textEditor.document.uri);
     const response = await moduleCallers(languageClient, moduleUri.toString());
 
     let selectedModule: string;

src/vscodeUtils.ts

@@ -20,6 +20,14 @@ export function getWorkspaceFolder(folderName: string): vscode.WorkspaceFolder {
   return vscode.workspace.getWorkspaceFolder(vscode.Uri.parse(folderName));
 }
 
+// getActiveTextEditor returns an active (visible and focused) TextEditor
+// We intentionally do *not* use vscode.window.activeTextEditor here
+// because it also contains Output panes which are considered editors
+// see also https://github.com/microsoft/vscode/issues/58869
+export function getActiveTextEditor(): vscode.TextEditor {
+  return vscode.window.visibleTextEditors.find((textEditor) => !!textEditor.viewColumn);
+}
+
 export function prunedFolderNames(
   folders: readonly vscode.WorkspaceFolder[] = vscode.workspace.workspaceFolders,
 ): string[] {