Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workflows for drafting and publishing a release #631

Merged
merged 3 commits into from
Sep 22, 2021
Merged

Conversation

aeschright
Copy link
Contributor

@aeschright aeschright commented May 12, 2021

Depends on


This could all be combined into one workflow if we have an automated way to parse the changelog into release notes.

This is pending as a draft until we have the token available.

@radeksimko radeksimko self-assigned this Sep 13, 2021
@radeksimko radeksimko marked this pull request as ready for review September 15, 2021 10:40
@radeksimko
Copy link
Member

Token was added to Secrets and I also modified the workflows according to my manual testing in a fork:
https://github.com/radeksimko/vscode-terraform/runs/3608892891

This enables us to cut releases in a single step/workflow.

Changelog in Marketplace entry is sourced automatically from Changelog.md anyway. We can continue updating that changelog manually and ensure it's not forgotten via a custom input where a maintainer has to confirm this.

We can also continue copy-pasting the relevant part of changelog into GitHub Release notes.

Lastly we should not need to continue publishing the vsix to GitHub as this encourages a bad practice of users installing released extension outside of Marketplace.

Screenshot 2021-09-15 at 11 41 49

Depends on:

@radeksimko radeksimko requested a review from a team September 15, 2021 10:43
@radeksimko radeksimko force-pushed the release branch 2 times, most recently from 865047b to 15ea39d Compare September 21, 2021 15:40
Changelog in Marketplace entry is sourced automatically from Changelog.md
We can continue updating that changelog manually.

We can also continue copy-pasting the relevant part of changelog
into GitHub Release notes.

We can use Linux instead of Windows since Windows is not a requirement for vsce.

Lastly we de-ephasise the vsix package as an artifact which can still be found
and used but ideally we want folks to install from the Marketplace.
This is a compromise between stopping publishing of vsix entirely vs
automatically creating a release to which we'd upload it as an asset.
@radeksimko
Copy link
Member

radeksimko commented Sep 21, 2021

@jpogran As discussed via Slack I made some further adjustments which I also documented in the commit log.

The release can now be triggered by tag push, although it's expected that we'd still manually create the GitHub Release - which can be done either as part of cutting the release and creating the tag (via GitHub web UI), or manually afterwards.

I also decided to still package the vsix and upload it as an artifact, which is purposefully harder to find (compared to being a release asset). This aligns with the goal that we want folks to install the extension from the Marketplace.

This is a compromise between stopping publishing of the vsix entirely and automatically creating a release to which we'd upload it as an asset. We can revisit this decision and either phase it out entirely (if nobody asks for it), or find a different solution.


I ran into some unrelated problems when trying to test this in a fork and describes some steps that would make it easier in #786

@jpogran
Copy link
Contributor

jpogran commented Sep 22, 2021

👍🏼 to revisiting automatically creating a Github release, there is alot we can bike shed with that. Ideally we could create the release with a section of our changelog, which would compliment the marketplace display. Right now automating the changelog would be non-trivial, maybe with things like github/roadmap#248 that will be easier.

Copy link
Contributor

@jpogran jpogran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@radeksimko
Copy link
Member

Ideally we could create the release with a section of our changelog, which would compliment the marketplace display.

FWIW the Marketplace already sources the changelog automatically from Changelog.md it appears:
https://marketplace.visualstudio.com/items/HashiCorp.terraform/changelog

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants