-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatically publish extension to OpenVSX (GitHub workflow) #388
Conversation
Update: The GitHub workflow seems to work as expected on my fork, right up to the (That call then fails with the error "A personal access token must be given", because I haven't set up the |
@jankeromnes thanks for this, should we just publish actual releases, or every push/commit? |
@paultyng You're very welcome. The proposed GitHub Action publishes on every push to If you have a dedicated mechanism for publishing actual releases, it may be better to run the I'm happy to adjust the PR if you point me to the official publishing script, but any way works for OpenVSX, so you can choose which option you prefer. |
(Friendly ping @paultyng @appilon @radeksimko 🙂) |
Apologies @jankeromnes for the radio silence. I see you've gone ahead and setup the automatic publishing through the generic OpenVSX account so that the extension is available in the OpenVSX gallery. We've recently added automatic publsihing for the VS Code Marketplace in #631, so we'll add this action to that workflow. You would need to rebase your PR and move these changes to that file, but likely since there has been so much time since you contributed this PR I can understand if you don't have time to do that. If so, I'll handle that when the account for the OpenVSX gallery is created and setup. I'm going to mark this as draft until then and add it to our planning board. |
@jpogran dropping in to the conversation to say that this still needs some time to work as expected, because OpenVSX doesn't yet support the target platform feature, which this extension uses. After the feature lands (eclipse/openvsx#406), I can take over this Pull Request to get it working (if @jankeromnes lets me 😛). This is one of the biggest extensions on OpenVSX and is currently failing to publish (there it is still at https://github.com/hashicorp/vscode-terraform/releases/tag/v2.18.0), so I would loooove to see this merged soon 🤞🧡. |
Hi @filiptronicek, many thanks for the offer! 🙏 I've added you as a collaborator on my fork, which should allow you to update this Pull Request. Please let me know if I can help with anything else. |
Closing in favour of #1064 |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Hello! 👋 Many thanks for the cool Terraform extension!
Fixes #379. This proof-of-concept GitHub workflow would:
master
ovsx
CLI)It requires:
OVSX_PAT
GitHub secret with value from https://open-vsx.org/user-settings/tokensNotes: