Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gitattributes: ensure all text files end with LF #773

Merged
merged 1 commit into from
Sep 15, 2021
Merged

Conversation

radeksimko
Copy link
Member

This is in preparation for automating marketplace publishing, which will run on GitHub-hosted Windows instance.

The original configuration has a few problems:

  • every file is treated as text (including files which should be treated as binaries)
  • some binary files have their line endings converted after checkout on Windows, which then prevents publishing
Run npx -- vsce publish 2.14.1
 ERROR  Command failed: npm version 2.14.1
npm ERR! Git working directory not clean.
npm ERR! M terraform-banner.png
npm ERR! M terraform.png

npm ERR! A complete log of this run can be found in:
npm ERR!     C:\npm\cache\_logs\2021-09-15T07_53_35_881Z-debug.log

@radeksimko radeksimko requested a review from a team September 15, 2021 08:56
Copy link
Contributor

@jpogran jpogran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼 Explicit is always better than implicit!

@radeksimko radeksimko merged commit b843ab3 into main Sep 15, 2021
@radeksimko radeksimko deleted the fix-line-endings branch September 15, 2021 13:48
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants