Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add feature flag for disabling precompile contracts #17548

Merged
merged 5 commits into from
Jan 27, 2025

Conversation

lukelee-sl
Copy link
Member

Description:
Add a feature flag for disabling calls to precompile contracts

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Luke Lee <luke.lee@hashgraph.com>
@lukelee-sl lukelee-sl added this to the v0.59 milestone Jan 25, 2025
@lukelee-sl lukelee-sl self-assigned this Jan 25, 2025
@lukelee-sl lukelee-sl requested review from tinker-michaelj and a team as code owners January 25, 2025 01:42
Copy link

codecov bot commented Jan 25, 2025

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 68.90%. Comparing base (e5b9213) to head (41af165).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
...pl/exec/processors/CustomMessageCallProcessor.java 33.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main   #17548      +/-   ##
============================================
- Coverage     68.94%   68.90%   -0.04%     
+ Complexity    22713    22704       -9     
============================================
  Files          2619     2617       -2     
  Lines         98103    98088      -15     
  Branches      10162    10165       +3     
============================================
- Hits          67636    67591      -45     
- Misses        26625    26650      +25     
- Partials       3842     3847       +5     
Files with missing lines Coverage Δ
...a/com/hedera/node/config/data/ContractsConfig.java 100.00% <ø> (ø)
...p/service/contract/impl/exec/utils/FrameUtils.java 96.07% <100.00%> (+0.20%) ⬆️
...pl/exec/processors/CustomMessageCallProcessor.java 86.23% <33.33%> (-1.62%) ⬇️

... and 33 files with indirect coverage changes

Impacted file tree graph

Copy link

codacy-production bot commented Jan 25, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.03% (target: -1.00%) 87.50%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (e5b9213) 97886 71327 72.87%
Head commit (41af165) 97871 (-15) 71287 (-40) 72.84% (-0.03%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#17548) 8 7 87.50%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Signed-off-by: Luke Lee <luke.lee@hashgraph.com>
Copy link
Contributor

@Nana-EC Nana-EC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG.
Some suggestions to consider

Nana-EC
Nana-EC previously approved these changes Jan 25, 2025
Copy link
Contributor

@Nana-EC Nana-EC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feedback can be explored in a potential follow up PR

Signed-off-by: Luke Lee <luke.lee@hashgraph.com>
Nana-EC
Nana-EC previously approved these changes Jan 25, 2025
Signed-off-by: Luke Lee <luke.lee@hashgraph.com>
Signed-off-by: Luke Lee <luke.lee@hashgraph.com>
Copy link
Collaborator

@tinker-michaelj tinker-michaelj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tyvm @lukelee-sl !

@lukelee-sl lukelee-sl merged commit 091f779 into main Jan 27, 2025
45 of 46 checks passed
@lukelee-sl lukelee-sl deleted the disable-precompiles-feature-flag branch January 27, 2025 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants