-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add feature flag for disabling precompile contracts #17548
Conversation
Signed-off-by: Luke Lee <luke.lee@hashgraph.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17548 +/- ##
============================================
- Coverage 68.94% 68.90% -0.04%
+ Complexity 22713 22704 -9
============================================
Files 2619 2617 -2
Lines 98103 98088 -15
Branches 10162 10165 +3
============================================
- Hits 67636 67591 -45
- Misses 26625 26650 +25
- Partials 3842 3847 +5
|
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
Signed-off-by: Luke Lee <luke.lee@hashgraph.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG.
Some suggestions to consider
...vice-impl/src/main/java/com/hedera/node/app/service/contract/impl/exec/utils/FrameUtils.java
Show resolved
Hide resolved
.../src/test/java/com/hedera/node/app/service/contract/impl/test/exec/utils/FrameUtilsTest.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feedback can be explored in a potential follow up PR
Signed-off-by: Luke Lee <luke.lee@hashgraph.com>
Signed-off-by: Luke Lee <luke.lee@hashgraph.com>
Signed-off-by: Luke Lee <luke.lee@hashgraph.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, tyvm @lukelee-sl !
Description:
Add a feature flag for disabling calls to precompile contracts
Notes for reviewer:
Checklist