Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: 17548 cherry pick into 0.58 #17550

Open
wants to merge 4 commits into
base: release/0.58
Choose a base branch
from

Conversation

lukelee-sl
Copy link
Member

Description:
Cherry pick #17548 into release 0.58

Signed-off-by: Luke Lee <luke.lee@hashgraph.com>
Signed-off-by: Luke Lee <luke.lee@hashgraph.com>
Signed-off-by: Luke Lee <luke.lee@hashgraph.com>
@lukelee-sl lukelee-sl added this to the v0.58 milestone Jan 25, 2025
@lukelee-sl lukelee-sl self-assigned this Jan 25, 2025
@lukelee-sl lukelee-sl requested review from a team and tinker-michaelj as code owners January 25, 2025 05:08
Signed-off-by: Luke Lee <luke.lee@hashgraph.com>
Copy link

codecov bot commented Jan 25, 2025

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 64.31%. Comparing base (c3cfc87) to head (6714625).

Files with missing lines Patch % Lines
...pl/exec/processors/CustomMessageCallProcessor.java 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff               @@
##             release/0.58   #17550   +/-   ##
===============================================
  Coverage           64.31%   64.31%           
- Complexity          20877    20878    +1     
===============================================
  Files                2549     2549           
  Lines               95950    95955    +5     
  Branches            10032    10033    +1     
===============================================
+ Hits                61708    61712    +4     
  Misses              30617    30617           
- Partials             3625     3626    +1     
Files with missing lines Coverage Δ
...a/com/hedera/node/config/data/ContractsConfig.java 100.00% <ø> (ø)
...p/service/contract/impl/exec/utils/FrameUtils.java 96.07% <100.00%> (+0.20%) ⬆️
...pl/exec/processors/CustomMessageCallProcessor.java 86.91% <0.00%> (-0.94%) ⬇️

Impacted file tree graph

Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%) 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (c3cfc87) 95713 65141 68.06%
Head commit (6714625) 95718 (+5) 65146 (+5) 68.06% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#17550) 6 6 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants