Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: 17548 cherry pick into 0.59 #17579

Merged
merged 5 commits into from
Jan 30, 2025
Merged

Conversation

lukelee-sl
Copy link
Member

Description:
Cherry pick #17548 into release 0.59

Signed-off-by: Luke Lee <luke.lee@hashgraph.com>
Signed-off-by: Luke Lee <luke.lee@hashgraph.com>
Signed-off-by: Luke Lee <luke.lee@hashgraph.com>
Signed-off-by: Luke Lee <luke.lee@hashgraph.com>
Signed-off-by: Luke Lee <luke.lee@hashgraph.com>
@lukelee-sl lukelee-sl requested review from a team and tinker-michaelj as code owners January 27, 2025 20:55
@lukelee-sl lukelee-sl added this to the v0.59 milestone Jan 27, 2025
@lukelee-sl lukelee-sl self-assigned this Jan 27, 2025
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.01% (target: -1.00%) 87.50%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (b44fa0a) 98457 71727 72.85%
Head commit (cfca94d) 98470 (+13) 71742 (+15) 72.86% (+0.01%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#17579) 8 7 87.50%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link

codecov bot commented Jan 27, 2025

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 68.90%. Comparing base (b44fa0a) to head (cfca94d).
Report is 1 commits behind head on release/0.59.

Files with missing lines Patch % Lines
...pl/exec/processors/CustomMessageCallProcessor.java 33.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff               @@
##             release/0.59   #17579   +/-   ##
===============================================
  Coverage           68.90%   68.90%           
- Complexity          22830    22834    +4     
===============================================
  Files                2630     2630           
  Lines               98674    98687   +13     
  Branches            10253    10257    +4     
===============================================
+ Hits                67990    68005   +15     
+ Misses              26796    26794    -2     
  Partials             3888     3888           
Files with missing lines Coverage Δ
...a/com/hedera/node/config/data/ContractsConfig.java 100.00% <ø> (ø)
...p/service/contract/impl/exec/utils/FrameUtils.java 96.07% <100.00%> (+0.20%) ⬆️
...pl/exec/processors/CustomMessageCallProcessor.java 86.23% <33.33%> (-1.62%) ⬇️

... and 3 files with indirect coverage changes

Impacted file tree graph

@lukelee-sl lukelee-sl changed the base branch from main to release/0.59 January 27, 2025 22:23
Copy link
Member

@david-bakin-sl david-bakin-sl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM cherry pick

Copy link
Collaborator

@tinker-michaelj tinker-michaelj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tyvm @lukelee-sl !

@derektriley derektriley merged commit cc7a187 into release/0.59 Jan 30, 2025
52 of 61 checks passed
@derektriley derektriley deleted the 17548-cherry-pick-into-59 branch January 30, 2025 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants