-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Fix bug with deleting xts-candidate tag prior to creation or use #16159
Conversation
**Description**: xts-candidate tag was failing to be deleted if it did not exist **Related Issue(s)**: Fixes: #16156 Signed-off-by: Roger Barker <roger.barker@swirldslabs.com>
Signed-off-by: Roger Barker <roger.barker@swirldslabs.com>
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #16159 +/- ##
==========================================
Coverage 58.08% 58.08%
Complexity 19799 19799
==========================================
Files 2726 2726
Lines 99917 99917
Branches 10320 10320
==========================================
Hits 58039 58039
Misses 38259 38259
Partials 3619 3619 |
Signed-off-by: Roger Barker <roger.barker@swirldslabs.com>
Node: Timing Sensitive Unit Test Results 91 files ±0 1 errors 90 suites ±0 29m 10s ⏱️ ±0s For more details on these parsing errors, see this check. Results for commit 21fd4b1. ± Comparison against base commit 8c4f948. |
* develop: feat: HIP-904 Implement TokenClaimAirdrop System Contract (#16054) ci: Fix bug with deleting xts-candidate tag prior to creation or use (#16159) ci: Fix ZXCron Promote Build Candidate Checkout Tagged Code step (#16154) ci: Add logic to only delete xts-candidate tag if it already exists (#16140) chore: migrate cryptography from .pfx to .pem files (#16025)
…16159) Signed-off-by: Roger Barker <roger.barker@swirldslabs.com>
Description:
xts-candidate tag was failing to be deleted if it did not exist
Related Issue(s):
Fixes: #16156
Checklist