Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Fix bug with deleting xts-candidate tag prior to creation or use #16159

Merged
merged 3 commits into from
Oct 25, 2024

Conversation

rbarkerSL
Copy link
Contributor

@rbarkerSL rbarkerSL commented Oct 24, 2024

Description:

xts-candidate tag was failing to be deleted if it did not exist

Related Issue(s):

Fixes: #16156

Checklist

**Description**:

xts-candidate tag was failing to be deleted if it did not exist

**Related Issue(s)**:

Fixes: #16156

Signed-off-by: Roger Barker <roger.barker@swirldslabs.com>
Signed-off-by: Roger Barker <roger.barker@swirldslabs.com>
@rbarkerSL rbarkerSL added Bug An error that causes the feature to behave differently than what was expected based on design. github_actions Pull requests that update GitHub Actions code labels Oct 24, 2024
@rbarkerSL rbarkerSL added this to the v0.56 milestone Oct 24, 2024
@rbarkerSL rbarkerSL self-assigned this Oct 24, 2024
@rbarkerSL rbarkerSL requested review from a team as code owners October 24, 2024 19:45
@rbarkerSL rbarkerSL requested a review from nathanklick October 24, 2024 19:46
Copy link

codacy-production bot commented Oct 24, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (8c4f948) 99734 61521 61.69%
Head commit (21fd4b1) 99734 (+0) 61521 (+0) 61.69% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#16159) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.08%. Comparing base (8c4f948) to head (21fd4b1).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             develop   #16159   +/-   ##
==========================================
  Coverage      58.08%   58.08%           
  Complexity     19799    19799           
==========================================
  Files           2726     2726           
  Lines          99917    99917           
  Branches       10320    10320           
==========================================
  Hits           58039    58039           
  Misses         38259    38259           
  Partials        3619     3619           

Impacted file tree graph

Signed-off-by: Roger Barker <roger.barker@swirldslabs.com>
Copy link

Node: Timing Sensitive Unit Test Results

   91 files  ±0      1 errors  90 suites  ±0   29m 10s ⏱️ ±0s
8 222 tests ±0  8 197 ✅ ±0  25 💤 ±0  0 ❌ ±0 
8 912 runs  ±0  8 887 ✅ ±0  25 💤 ±0  0 ❌ ±0 

For more details on these parsing errors, see this check.

Results for commit 21fd4b1. ± Comparison against base commit 8c4f948.

@rbarkerSL rbarkerSL merged commit 6620006 into develop Oct 25, 2024
61 of 65 checks passed
@rbarkerSL rbarkerSL deleted the 16156-fix-xts-candidate-checks branch October 25, 2024 03:10
netopyr added a commit that referenced this pull request Oct 25, 2024
* develop:
  feat: HIP-904 Implement TokenClaimAirdrop System Contract (#16054)
  ci: Fix bug with deleting xts-candidate tag prior to creation or use  (#16159)
  ci: Fix ZXCron Promote Build Candidate Checkout Tagged Code step (#16154)
  ci: Add logic to only delete xts-candidate tag if it already exists (#16140)
  chore: migrate cryptography from .pfx to .pem files (#16025)
Evdokia-Georgieva pushed a commit that referenced this pull request Oct 31, 2024
…16159)

Signed-off-by: Roger Barker <roger.barker@swirldslabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug An error that causes the feature to behave differently than what was expected based on design. github_actions Pull requests that update GitHub Actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

prepare xts and run xts flows fail if precursor tag does not already exist in the repository
2 participants