-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: HIP-904 Implement TokenClaimAirdrop System Contract #16054
Conversation
Signed-off-by: Stanimir Stoyanov <stanimir.stoyanov@limechain.tech>
Signed-off-by: Stanimir Stoyanov <stanimir.stoyanov@limechain.tech>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #16054 +/- ##
=============================================
+ Coverage 58.05% 58.08% +0.03%
- Complexity 19765 19791 +26
=============================================
Files 2726 2728 +2
Lines 99747 99824 +77
Branches 10295 10304 +9
=============================================
+ Hits 57908 57986 +78
Misses 38233 38233
+ Partials 3606 3605 -1
|
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
Signed-off-by: Stanimir Stoyanov <stanimir.stoyanov@limechain.tech>
Node: HAPI Test (Restart) Results9 files 1 errors 8 suites 7m 20s ⏱️ For more details on these parsing errors, see this check. Results for commit a6a3a82. ♻️ This comment has been updated with latest results. |
Signed-off-by: Stanimir Stoyanov <stanimir.stoyanov@limechain.tech>
Signed-off-by: Stanimir Stoyanov <stanimir.stoyanov@limechain.tech>
Signed-off-by: Stanimir Stoyanov <stanimir.stoyanov@limechain.tech>
Signed-off-by: Stanimir Stoyanov <stanimir.stoyanov@limechain.tech>
.../com/hedera/node/app/service/contract/impl/test/exec/systemcontracts/CallAttemptHelpers.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG. The code here is very similar to the Cancel Airdrop pr. I wonder if it is worth considering if there is room for more sharing between the 2 prs?
I plan to add a follow up PR to extract the common logic or update the second PR whenever we merge the first (whichever gods in first) |
# Conflicts: # hedera-node/hedera-smart-contract-service-impl/src/main/java/com/hedera/node/app/service/contract/impl/exec/gas/DispatchType.java # hedera-node/hedera-smart-contract-service-impl/src/main/java/com/hedera/node/app/service/contract/impl/exec/processors/HtsTranslatorsModule.java
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* develop: feat: HIP-904 Implement TokenClaimAirdrop System Contract (#16054) ci: Fix bug with deleting xts-candidate tag prior to creation or use (#16159) ci: Fix ZXCron Promote Build Candidate Checkout Tagged Code step (#16154) ci: Add logic to only delete xts-candidate tag if it already exists (#16140) chore: migrate cryptography from .pfx to .pem files (#16025)
Signed-off-by: Stanimir Stoyanov <stanimir.stoyanov@limechain.tech>
Description:
This PR aims to implement the TokenClaimAirdrop system contract described in https://github.com/hashgraph/hedera-services/pull/15435/files?short_path=03ab1e7#diff-03ab1e73f0ded9a04739c3b1a68c13f779dce416cd2f7b6637b03d8e2e41e105
Related issue(s):
Fixes #15590
Notes for reviewer:
This feature is enabled only for dev and previewnet envs.
Checklist