Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prepare xts and run xts flows fail if precursor tag does not already exist in the repository #16156

Closed
rbarkerSL opened this issue Oct 24, 2024 · 0 comments · Fixed by #16159
Closed
Assignees
Labels
Bug An error that causes the feature to behave differently than what was expected based on design. github_actions Pull requests that update GitHub Actions code
Milestone

Comments

@rbarkerSL
Copy link
Contributor

Description

When ZXF: Prepare Extended Test Suite and ZXCron: Extended Test Suite workflows run they perform the following check:

        name: Check for tags
        id: check-tags-exist
        run: |
          XTS_COMMIT=$(git rev-list -n 1 "${XTS_CANDIDATE_TAG}")
          set +e
          git branch --contains "${XTS_COMMIT}" | grep --quiet develop >/dev/null 2>&1
          BRANCH_ON_DEVELOP="${?}"
          set -e
          if [[ -n "${XTS_COMMIT}" && "${BRANCH_ON_DEVELOP}" -eq 0 ]]; then
            ....
          fi

If the precursor tag xts-commit does not exist in the repository flow the first check XTS_COMMIT=$(git rev-list -n 1 "${XTS_CANDIDATE_TAG}") will error out saying:

fatal: ambiguous argument 'xts-candidate': unknown revision or path not in the working tree.
Use '--' to separate paths from revisions, like this:
'git <command> [<revision>...] -- [<file>...]'

Steps to reproduce

Manually trigger either workflow

Additional context

Both of these workflows should pass through that check and either create the tag or consume the tag regardless of its presence.

Hedera network

No response

Version

develop

Operating system

Linux

@rbarkerSL rbarkerSL added Bug An error that causes the feature to behave differently than what was expected based on design. github_actions Pull requests that update GitHub Actions code labels Oct 24, 2024
@rbarkerSL rbarkerSL added this to the v0.56 milestone Oct 24, 2024
@rbarkerSL rbarkerSL self-assigned this Oct 24, 2024
rbarkerSL added a commit that referenced this issue Oct 24, 2024
**Description**:

xts-candidate tag was failing to be deleted if it did not exist

**Related Issue(s)**:

Fixes: #16156

Signed-off-by: Roger Barker <roger.barker@swirldslabs.com>
@rbarkerSL rbarkerSL linked a pull request Oct 24, 2024 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug An error that causes the feature to behave differently than what was expected based on design. github_actions Pull requests that update GitHub Actions code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant