Use built-in zsh function to get absolute dir path #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should fix #135 for zsh There is on need to change the directory, please see https://linux.die.net/man/1/zshexpn for explanation
This update has been forgotten to commit in the first commit of this PR Now it works exactly as the original version, but does not change the directory to get the absolute directory name
|
This is awesome! Thank you! |
halcyon
requested changes
Apr 6, 2021
delgurth
added a commit
to delgurth/asdf-java
that referenced
this pull request
Apr 6, 2021
… with review comment of @halcyon
|
Merged #144 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #135 for zsh
There is no need to change the directory, please see https://linux.die.net/man/1/zshexpn for explanation