[macOS] Zulu install for /usr/libexec/java_home does not work #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ail to return the expected result. Changed it to bin/.. Fixes halcyon#137
…ed in /usr/libexec/java_home
|
I've added a test to see if java_home works as expected. Also added some information when installing Liberica JVM's about it not working for the java_home install. Only the .pkg version of the Liberica version contains the Info.plist and MacOS folder. |
|
Removed the commits from the update-data script. And added a condition so this script will only run on the main repository. |
|
LGTM! Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced file
releasewithbin/..to fix #137.